Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2359803003: Job Controller: clean up metrics logging about the job racing result (Closed)

Created:
4 years, 3 months ago by Zhongyi Shi
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton, tbansal1
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Job Controller: clean up metrics logging about the job racing result BUG=605398 Committed: https://crrev.com/7935a5593b82798f2f054dcde0f1007405a0e911 Cr-Commit-Position: refs/heads/master@{#421059}

Patch Set 1 #

Total comments: 9

Patch Set 2 : nits #

Total comments: 1

Patch Set 3 : move proxy-server specific enum to anonymous namespace #

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -59 lines) Patch
M net/http/http_server_properties.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_server_properties.cc View 1 2 3 1 chunk +41 lines, -3 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 1 2 3 3 chunks +22 lines, -33 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
Zhongyi Shi
Moving metrics logging to controller. And try to minimize the code duplication when logging. ptal!
4 years, 3 months ago (2016-09-21 19:32:55 UTC) #4
tbansal1
Thanks for doing this. https://codereview.chromium.org/2359803003/diff/1/net/http/http_server_properties.cc File net/http/http_server_properties.cc (right): https://codereview.chromium.org/2359803003/diff/1/net/http/http_server_properties.cc#newcode26 net/http/http_server_properties.cc:26: default: Add NOTREACHED() in default: ...
4 years, 3 months ago (2016-09-22 17:53:03 UTC) #7
Ryan Hamilton
Thanks for doing this. Just on comment in a addition to tbansal's https://codereview.chromium.org/2359803003/diff/1/net/http/http_stream_factory_impl_job_controller.cc File net/http/http_stream_factory_impl_job_controller.cc ...
4 years, 3 months ago (2016-09-22 21:46:33 UTC) #8
Zhongyi Shi
Nits addressed, ptal! https://codereview.chromium.org/2359803003/diff/1/net/http/http_server_properties.cc File net/http/http_server_properties.cc (right): https://codereview.chromium.org/2359803003/diff/1/net/http/http_server_properties.cc#newcode26 net/http/http_server_properties.cc:26: default: On 2016/09/22 17:53:02, tbansal1 wrote: ...
4 years, 3 months ago (2016-09-22 23:56:53 UTC) #9
tbansal1
lgtm % 1 nit. Thanks for doing this. https://codereview.chromium.org/2359803003/diff/1/net/http/http_stream_factory_impl_job_controller.cc File net/http/http_stream_factory_impl_job_controller.cc (right): https://codereview.chromium.org/2359803003/diff/1/net/http/http_stream_factory_impl_job_controller.cc#newcode1053 net/http/http_stream_factory_impl_job_controller.cc:1053: DCHECK(main_job_ ...
4 years, 3 months ago (2016-09-23 00:02:07 UTC) #10
Ryan Hamilton
lgtm
4 years, 3 months ago (2016-09-23 19:20:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359803003/40001
4 years, 2 months ago (2016-09-26 20:02:25 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/134681) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 2 months ago (2016-09-26 20:06:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359803003/60001
4 years, 2 months ago (2016-09-26 22:13:43 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/284558)
4 years, 2 months ago (2016-09-26 23:24:21 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359803003/60001
4 years, 2 months ago (2016-09-26 23:45:39 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-27 00:57:57 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 01:04:44 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7935a5593b82798f2f054dcde0f1007405a0e911
Cr-Commit-Position: refs/heads/master@{#421059}

Powered by Google App Engine
This is Rietveld 408576698