Issue 23598011: Use icu_gyp_path variable to reference ICU gyp file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23598011: Use icu_gyp_path variable to reference ICU gyp file (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Use icu_gyp_path variable to reference ICU gyp file That way, embedders can put the icu sources whereever they want and aren't forced to put them under third_party/gyp BUG=none R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16749

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -9 lines)			Patch
M	build/standalone.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	samples/samples.gyp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/d8.gyp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

7 years, 3 months ago (2013-09-17 08:32:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16749 (presubmit successful).