Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: pkg/intl/lib/generate_localized.dart

Issue 23598003: Disable Intl deferred loading until it works in dart2js (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/lib/generate_localized.dart
diff --git a/pkg/intl/lib/generate_localized.dart b/pkg/intl/lib/generate_localized.dart
index 5f9639f9b5a92de002cb7225e9a831ae43dcab9a..f72af3fb0a0255b5a781b51dc28c72b805b44055 100644
--- a/pkg/intl/lib/generate_localized.dart
+++ b/pkg/intl/lib/generate_localized.dart
@@ -159,7 +159,9 @@ String generateMainImportFile() {
for (var locale in allLocales) {
var baseFile = '${generatedFilePrefix}messages_$locale.dart';
var file = importForGeneratedFile(baseFile);
- output.write("@${_deferredName(locale)}\n");
+ // TODO(alanknight): Restore this once deferred loading works in dartj2s.
+ // Issue 12824
+ // output.write("@${_deferredName(locale)}\n");
output.write("import '$file' as ${_libraryName(locale)};\n");
}
output.write("\n");
@@ -215,8 +217,10 @@ const closing = """
Future initializeMessages(String localeName) {
initializeInternalMessageLookup(() => new CompositeMessageLookup());
messageLookup.addLocale(localeName, _findGeneratedMessagesFor);
- var lib = deferredLibraries[localeName];
- return lib == null ? new Future.value(false) : lib.load();
+ var lib = deferredLibraries[localeName];
+ // TODO(alanknight): Restore once Issue 12824 is fixed.
+ // return lib == null ? new Future.value(false) : lib.load();
+ return new Future.value(true);
}
MessageLookupByLibrary _findGeneratedMessagesFor(locale) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698