Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: net/data/parse_certificate_unittest/extension_critical_3.pem

Issue 2359783003: Convert tests that parse an Extension value to instead (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/data/parse_certificate_unittest/extension_critical_3.pem
diff --git a/net/data/parse_certificate_unittest/extension_critical_3.pem b/net/data/parse_certificate_unittest/extension_critical_3.pem
index 97b8f08ab48efe2af9606b1b45397758b051f604..c9d904ad1792c4d9245cecf1893c57ce93835417 100644
--- a/net/data/parse_certificate_unittest/extension_critical_3.pem
+++ b/net/data/parse_certificate_unittest/extension_critical_3.pem
@@ -1,14 +1,20 @@
-This is a basic constraints extension, where the critical field (BOOLEAN) is 3.
+This is an unknown extension, where the critical field (BOOLEAN) is 3.
This is not valid because BOOLEANs in DER-encoding should use an octet of
either all 0 bits or all 1 bits.
+#-----BEGIN EXTENSION-----
+SEQUENCE {
+ # https://davidben.net/oid
+ OBJECT_IDENTIFIER { 1.2.840.113554.4.1.72585.0 }
+ BOOLEAN { `03` }
+ OCTET_STRING {
+ SEQUENCE {}
+ }
+}
+#-----END EXTENSION-----
-$ openssl asn1parse -i < [EXTENSION]
- 0:d=0 hl=2 l= 12 cons: SEQUENCE
- 2:d=1 hl=2 l= 3 prim: OBJECT :X509v3 Basic Constraints
- 7:d=1 hl=2 l= 1 prim: BOOLEAN :3
- 10:d=1 hl=2 l= 2 prim: OCTET STRING [HEX DUMP]:3000
------BEGIN EXTENSION-----
-MAwGA1UdEwEBAwQCMAA=
------END EXTENSION-----
+
+-----BEGIN CERTIFICATE-----
+MIICbzCCAdigAwIBAgIJAPuwTC6rEJsMMA0GCSqGSIb3DQEBBQUAMEUxCzAJBgNVBAYTAkFVMRMwEQYDVQQIDApTb21lLVN0YXRlMSEwHwYDVQQKDBhJbnRlcm5ldCBXaWRnaXRzIFB0eSBMdGQwHhcNMTQwNDIzMjA1MDQwWhcNMTcwNDIyMjA1MDQwWjBFMQswCQYDVQQGEwJBVTETMBEGA1UECAwKU29tZS1TdGF0ZTEhMB8GA1UECgwYSW50ZXJuZXQgV2lkZ2l0cyBQdHkgTHRkMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDYK8imMuRi/03z0K1Zi0WnvfFHvwlYeyK9Na6XJYaUoIDAtB92kWdGMdAQhLciHnAjkXLI6W15OoV3gA/ElRZ1xUpxTMhjP6PyY5wqT5r6y8FxbiiFKKAnHmUcrgfVW28tQ+0rkLGMryRtrukXOgXBv7gcrmU7G1jC2a7WqmeI8QIDAQABo2cwZTAdBgNVHQ4EFgQUi3XVrMsIvg4fZbf6Vr5sp3Xaha8wHwYDVR0jBBgwFoAUi3XVrMsIvg4fZbf6Vr5sp3Xaha8wDAYDVR0TBAUwAwEB/zAVBgwqhkiG9xIEAYS3CQABAQMEAjAAMA0GCSqGSIb3DQEBBQUAA4GBADvoeG2V1j1q9xMZLBvCiK4iq/SNMvV8cWfPLdEcwsOH4um+iVzkNKtIkcI/la4rR54leGtPmhCkcv3P9wIMsAoIpFri5XR+ER05YGrJH2nzLmMm3J7va3oK4VRXmKpykXgEfh+PZU0fCxKsnCQPhBQaVS0fu/CdCbIIXFkyZYAm
+-----END CERTIFICATE-----

Powered by Google App Engine
This is Rietveld 408576698