[Download Home] Various M55 adjustments

[Download Home] Various M55 adjustments

* Replace "Open externally" with "Open with..." and force a chooser to
  appear when there's more than one possibility for an app, even if the
  user has a default set.

* Replace file size display with logical size values that are smaller
  than GB

* Replace X with <-

BUG=650451, 650447, 643795
Committed: https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f
Cr-Commit-Position: refs/heads/master@{#421933}

[gone, 2016-09-22 01:11:12]

Description was changed from

==========
[Download Home]

* Replace Open externally with Open with...

* Replace file size display with logical size values that are smaller than GB

BUG=
==========

to

==========
[Download Home] Change strings, hide Download Home 

* Replace Open externally with Open with...

* Replace file size display with logical size values that are smaller than GB

* Start up Download Home safely in more scenarios.

BUG=616324
==========

[gone, 2016-09-22 01:11:38]

Just adding you two as FYI on this CL for now.

[gone, 2016-09-29 17:53:54]

Description was changed from

==========
[Download Home] Change strings, hide Download Home 

* Replace Open externally with Open with...

* Replace file size display with logical size values that are smaller than GB

* Start up Download Home safely in more scenarios.

BUG=616324
==========

to

==========
[Download Home] Various M55 adjustments

* Replace "Open externally" with "Open with..." and force a chooser to
  appear when there's more than one possibility for an app, even if the
  user has a default set.

* Replace file size display with logical size values that are smaller
  than GB

* Replace X with <-

BUG=650451,650447,643795
==========

[gone, 2016-09-29 17:54:17]

dfalcantara@chromium.org changed reviewers:
+ ianwen@chromium.org, twellington@chromium.org

[gone, 2016-09-29 17:54:18]

Guess this is ready to review.  PTAL.

[Theresa, 2016-09-29 18:11:04]

lgtm

https://codereview.chromium.org/2359763003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
(right):

https://codereview.chromium.org/2359763003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:348:
// in these cases prevent the Intent from firing correctly.
s/prevent/prevents

[Ian Wen, 2016-09-29 18:47:29]

CCT lgtm

[gone, 2016-09-29 18:54:23]

https://codereview.chromium.org/2359763003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
(right):

https://codereview.chromium.org/2359763003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:348:
// in these cases prevent the Intent from firing correctly.
On 2016/09/29 18:11:04, Theresa Wellington wrote:
> s/prevent/prevents

Done.

[gone, 2016-09-29 18:54:27]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-09-29 18:54:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, ianwen@chromium.org
Link to the patchset: https://codereview.chromium.org/2359763003/#ps40001
(title: "Nits")

[commit-bot: I haz the power, 2016-09-29 18:54:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 20:29:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 20:29:37]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gone, 2016-09-29 20:38:07]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-09-29 20:38:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, ianwen@chromium.org
Link to the patchset: https://codereview.chromium.org/2359763003/#ps60001
(title: "Tests")

[commit-bot: I haz the power, 2016-09-29 20:38:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 21:15:09]

Description was changed from

==========
[Download Home] Various M55 adjustments

* Replace "Open externally" with "Open with..." and force a chooser to
  appear when there's more than one possibility for an app, even if the
  user has a default set.

* Replace file size display with logical size values that are smaller
  than GB

* Replace X with <-

BUG=650451,650447,643795
==========

to

==========
[Download Home] Various M55 adjustments

* Replace "Open externally" with "Open with..." and force a chooser to
  appear when there's more than one possibility for an app, even if the
  user has a default set.

* Replace file size display with logical size values that are smaller
  than GB

* Replace X with <-

BUG=650451,650447,643795
==========

[commit-bot: I haz the power, 2016-09-29 21:15:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-29 21:18:22]

Description was changed from

==========
[Download Home] Various M55 adjustments

* Replace "Open externally" with "Open with..." and force a chooser to
  appear when there's more than one possibility for an app, even if the
  user has a default set.

* Replace file size display with logical size values that are smaller
  than GB

* Replace X with <-

BUG=650451,650447,643795
==========

to

==========
[Download Home] Various M55 adjustments

* Replace "Open externally" with "Open with..." and force a chooser to
  appear when there's more than one possibility for an app, even if the
  user has a default set.

* Replace file size display with logical size values that are smaller
  than GB

* Replace X with <-

BUG=650451,650447,643795

Committed: https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f
Cr-Commit-Position: refs/heads/master@{#421933}
==========

[commit-bot: I haz the power, 2016-09-29 21:18:23]

Patchset 4 (id:??) landed as
https://crrev.com/4f5ce82e33afe872b6959dc381925666b14a413f
Cr-Commit-Position: refs/heads/master@{#421933}