chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java - Issue 2359753002: Fix the IllegalStateException in OtherFormsOfHistoryDialogFragment.show()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java

Issue 2359753002: Fix the IllegalStateException in OtherFormsOfHistoryDialogFragment.show() (Closed)

Patch Set: MultiWindowUtils.isActivityVisible Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java

index 6f1bbfcfd67de0d7cf78f6b87a460248f2ad19c9..5e8171cf377ef20be34a06c15494fb5572ff7ec0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java

@@ -255,7 +255,11 @@ public class MultiWindowUtils implements ActivityStateListener {

return false;

}

- private boolean isActivityVisible(Activity activity) {

+ /**

+ * @param activity The Activity whose visibility to test.

+ * @return True iff the given Activity is currently visible.

+ */

+ public static boolean isActivityVisible(Activity activity) {

if (activity == null) return false;

int activityState = ApplicationStatus.getStateForActivity(activity);

// In Android N multi-window mode, only one activity is resumed at a time. The other