PlzNavigate: update navigation only if it took place.

third_party/WebKit/Source/web/WebDataSourceImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 59 matching lines @@
     return DocumentLoader::unreachableURL();
 }
 
 void WebDataSourceImpl::appendRedirect(const WebURL& url)
 {
     DocumentLoader::appendRedirect(url);
 }
 
 void WebDataSourceImpl::updateNavigation(double redirectStartTime, double redirectEndTime, double fetchStartTime, const WebVector<WebURL>& redirectChain)
 {
-    for (size_t i = 0; i + 1 < redirectChain.size(); ++i)
-        didRedirect(redirectChain[i], redirectChain[i + 1]);
-    timing().setRedirectStart(redirectStartTime);
-    timing().setRedirectEnd(redirectEndTime);
+    if (redirectChain.size() >= 2) {

[clamy, 2016/09/23 15:35:38]

This does not seem related to the other issue and the CL description. Please put
it in another CL if this relates to another issue, or remove it if it is no
longer needed.

[arthursonzogni, 2016/09/26 08:30:32]

There are related because they cause the same assertion violation.
Without it, only one of TracingBrowserTest still pass and the renderer crash.

Nevertheless, I think it may be better to do two different patchs.

+        for (size_t i = 0; i + 1 < redirectChain.size(); ++i)
+            didRedirect(redirectChain[i], redirectChain[i + 1]);
+        timing().setRedirectStart(redirectStartTime);
+        timing().setRedirectEnd(redirectEndTime);
+    }
     timing().setFetchStart(fetchStartTime);
 }
 
 void WebDataSourceImpl::redirectChain(WebVector<WebURL>& result) const
 {
     result.assign(m_redirectChain);
 }
 
 bool WebDataSourceImpl::isClientRedirect() const
 {
@@ skipping 69 matching lines @@
 {
     DocumentLoader::setSubresourceFilter(WTF::wrapUnique(subresourceFilter));
 }
 
 DEFINE_TRACE(WebDataSourceImpl)
 {
     DocumentLoader::trace(visitor);
 }
 
 } // namespace blink