Make HttpNetworkSession a client of memory coordinator

net/http/http_network_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_session.h"
 
 #include <utility>
 
 #include "base/atomic_sequence_num.h"
 #include "base/compiler_specific.h"
 #include "base/debug/stack_trace.h"
 #include "base/logging.h"
+#include "base/memory/memory_coordinator_client_registry.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "net/http/http_auth_handler_factory.h"
 #include "net/http/http_response_body_drainer.h"
 #include "net/http/http_stream_factory_impl.h"
 #include "net/http/url_security_manager.h"
 #include "net/proxy/proxy_service.h"
@@ skipping 206 matching lines @@
         true;
   }
 
   next_protos_.push_back(kProtoHTTP11);
 
   http_server_properties_->SetMaxServerConfigsStoredInProperties(
       params.quic_max_server_configs_stored_in_properties);
 
   memory_pressure_listener_.reset(new base::MemoryPressureListener(base::Bind(
       &HttpNetworkSession::OnMemoryPressure, base::Unretained(this))));
+  base::MemoryCoordinatorClientRegistry::GetInstance()->Register(this);
 }
 
 HttpNetworkSession::~HttpNetworkSession() {
   base::STLDeleteElements(&response_drainers_);
   spdy_session_pool_.CloseAllSessions();
+  base::MemoryCoordinatorClientRegistry::GetInstance()->Unregister(this);
 }
 
 void HttpNetworkSession::AddResponseDrainer(HttpResponseBodyDrainer* drainer) {
   DCHECK(!base::ContainsKey(response_drainers_, drainer));
   response_drainers_.insert(drainer);
 }
 
 void HttpNetworkSession::RemoveResponseDrainer(
     HttpResponseBodyDrainer* drainer) {
   DCHECK(base::ContainsKey(response_drainers_, drainer));
@@ skipping 143 matching lines @@
   switch (memory_pressure_level) {
     case base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_NONE:
       break;
     case base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE:
     case base::MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL:
       CloseIdleConnections();
       break;
   }
 }
 
+void HttpNetworkSession::OnMemoryStateChange(base::MemoryState state) {
+  // TODO(hajimehoshi): As OnMemoryStateChange changes the state, we should
+  // adjust the limitation to the amount of cache, HttpNetworkSession doesn't
+  // have such limitation so far though.

[Ryan Sleevi, 2016/09/26 15:15:59]

I often link to
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/NH-S6KCkr2M/dis...
for comments like this

// TODO(hajimehoshi): When the state changes, adjust the sizes of the caches to
reduce the limits. HttpNetworkSession doesn't have the ability to limit at
present.

(Assuming I understood the comment properly)

[hajimehoshi, 2016/09/27 11:39:29]

Done.

[hajimehoshi, 2016/09/27 11:39:29]

Done.

+  switch (state) {
+    case base::MemoryState::NORMAL:
+      break;
+    case base::MemoryState::THROTTLED:
+      // TOOD(hajimehoshi): We don't have throttling 'level' so far. When we
+      // have such value, let's change the argument accroding to the value.

[Ryan Sleevi, 2016/09/26 15:15:59]

Typo: according

But I'm also uncertain what this comment is trying to say. Is it trying to
document how //components/memory_coordinator is implemented? If so, it feels
like a layering violation - nothing will update this comment appropriately.

If there is a broader discussion of what to do when throttled, perhaps filing a
bug to attach to and explain sufficient context about what is going on makes
more sense than the comment here.

[hajimehoshi, 2016/09/27 11:39:29]

Done (removed). IIRC we don't have any plan to add this yet.

+      CloseIdleConnections();
+      break;
+    case base::MemoryState::SUSPENDED:
+    // Note that SUSPENDED never occurs in the main browser process so far.

[Ryan Sleevi, 2016/09/26 15:15:59]

//net shouldn't talk about things like "main browser process" - that's a
layering violation (//net is used in more than Chrome, but also shouldn't know
about how //chrome or //components are implemented)

case base::MemoryState::SUSPENDED:
  // Note: Not supported at present. Fall through.
case base::MemoryState::UNKNOWN:
  NOTREACHED();
  break;

[hajimehoshi, 2016/09/27 11:39:29]

Done.

+    // Fall through.
+    case base::MemoryState::UNKNOWN:
+      NOTREACHED();
+      break;
+  }
+}
+
 }  // namespace net