Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2359723004: [arm64] Check sign with TBZ/TBNZ. (Closed)

Created:
4 years, 3 months ago by georgia.kouveli
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Check sign with TBZ/TBNZ. Generate TBZ/TBNZ for certain comparisons against zero. E.g. instead of: cmp w0, 0x0 b.lt/ge <addr> we can generate: tbnz/tbz w0, 31, <addr> BUG= Committed: https://crrev.com/5b81f5868d8a938b974cde56a9e2d9f75f650ddb Cr-Commit-Position: refs/heads/master@{#39620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -73 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +94 lines, -3 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 12 chunks +104 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
georgia.kouveli
4 years, 3 months ago (2016-09-22 09:51:25 UTC) #2
Benedikt Meurer
LGTM.
4 years, 3 months ago (2016-09-22 09:52:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359723004/1
4 years, 3 months ago (2016-09-22 09:55:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 10:24:39 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 10:25:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b81f5868d8a938b974cde56a9e2d9f75f650ddb
Cr-Commit-Position: refs/heads/master@{#39620}

Powered by Google App Engine
This is Rietveld 408576698