Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2359723002: Prune CreateVisiblePositionDeprecated from most of VisibleUnits (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune CreateVisiblePositionDeprecated from most of VisibleUnits BUG=647219 Committed: https://crrev.com/64704e7062fad45e7fcb17f307a4904fc81f11fa Cr-Commit-Position: refs/heads/master@{#420050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -28 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 30 chunks +53 lines, -28 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-21 12:36:43 UTC) #4
yosin_UTC9
lgtm
4 years, 3 months ago (2016-09-21 14:33:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359723002/1
4 years, 3 months ago (2016-09-21 14:34:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 14:39:27 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 14:41:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64704e7062fad45e7fcb17f307a4904fc81f11fa
Cr-Commit-Position: refs/heads/master@{#420050}

Powered by Google App Engine
This is Rietveld 408576698