Issue 23597037: Unify handling of position info in AST, part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23597037: Unify handling of position info in AST, part 2 (Closed)

Created:
7 years, 3 months ago by rossberg

Modified:
7 years, 2 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Unify handling of position info in AST, part 2 * Eliminate Conditional::then/else_position and WhileStatement::condition_position. R=yangguo@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=17184

Created: 7 years, 3 months ago

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -38 lines)
M	src/ast.h	View	7 chunks	+1 line, -23 lines	0 comments
M	src/full-codegen.h	View	1 chunk	+1 line, -1 line	0 comments
M	src/full-codegen.cc	View	5 chunks	+6 lines, -8 lines	0 comments
M	src/parser.cc	View	2 chunks	+1 line, -6 lines	0 comments

Total messages: 3 (0 generated)

rossberg

7 years, 2 months ago (2013-10-14 09:41:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17184 (presubmit successful).