Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 23597036: Convert USE(NATIVE_FULLSCREEN_VIDEO) to a runtime enabled feature (Closed)

Created:
7 years, 3 months ago by trchen
Modified:
7 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@build_hack
Visibility:
Public.

Description

Convert USE(NATIVE_FULLSCREEN_VIDEO) to a runtime enabled feature This patch adds the boilerplate code to propagate command line switch to Blink, and selectively enables alpha channel in content_shell for layout tests. Blink patch: https://codereview.chromium.org/22454003 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225412

Patch Set 1 #

Patch Set 2 : CONTENT_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M content/browser/android/content_startup_flags.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/browser/webkit_test_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
trchen
Hello reviewers, This is a dependency of https://codereview.chromium.org/22454003 which is an Android-specific feature, to use ...
7 years, 3 months ago (2013-09-12 11:01:52 UTC) #1
trchen
Hello reviewers, Please take a look at this patch. This patch is basically stubs that ...
7 years, 3 months ago (2013-09-21 00:35:30 UTC) #2
jam
lgtm
7 years, 3 months ago (2013-09-23 17:52:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/23597036/1
7 years, 3 months ago (2013-09-23 19:00:36 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-23 19:39:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/23597036/1
7 years, 3 months ago (2013-09-24 21:02:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/23597036/1
7 years, 2 months ago (2013-09-25 21:48:53 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-09-26 02:30:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/23597036/61001
7 years, 2 months ago (2013-09-26 02:30:13 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 09:19:12 UTC) #10
Message was sent while issue was closed.
Change committed as 225412

Powered by Google App Engine
This is Rietveld 408576698