Issue 23597011: Revert 220467 "Added basic browser test for window.print() from ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23597011: Revert 220467 "Added basic browser test for window.print() from ..." (Closed)

Created:
7 years, 3 months ago by dharcourt

Modified:
7 years, 3 months ago

Reviewers:
dharcourt

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 220467 "Added basic browser test for window.print() from ..." > Added basic browser test for window.print() from Chrome apps. > > This just tests the success of the call to window.print(). It does not > test whether the call leads to a print preview window and ultimately to > a printout. It will be extended over time to provide additional coverage > of the print functionality. > > BUG=NONE > > Review URL: https://chromiumcodereview.appspot.com/23054002 TBR=dharcourt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220472

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -88 lines)			Patch
M	trunk/src/chrome/browser/apps/app_browsertest.cc	View	2 chunks	+0 lines, -30 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui.cc	View	2 chunks	+2 lines, -16 lines	0 comments	Download
D	trunk/src/chrome/test/data/extensions/platform_apps/print_api/manifest.json	View	1 chunk	+0 lines, -11 lines	0 comments	Download
D	trunk/src/chrome/test/data/extensions/platform_apps/print_api/test.html	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	trunk/src/chrome/test/data/extensions/platform_apps/print_api/test.js	View	1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r220472.

Expand Messages | Collapse Messages