Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2359663003: SELECT popup should respect to the minimum font size setting (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-minimum-font-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index 255a9a76a77cf45c4c260a648cec179249b62aca..81024d4f3ca2300b498884095dbadca0c56e3148 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -276,13 +276,16 @@ bool WebPagePopupImpl::initializePage()
m_chromeClient = PagePopupChromeClient::create(this);
pageClients.chromeClient = m_chromeClient.get();
+ Settings& mainSettings = m_webView->page()->settings();
m_page = Page::create(pageClients);
m_page->settings().setScriptEnabled(true);
m_page->settings().setAllowScriptsToCloseWindows(true);
- m_page->settings().setDeviceSupportsTouch(m_webView->page()->settings().deviceSupportsTouch());
+ m_page->settings().setDeviceSupportsTouch(mainSettings.deviceSupportsTouch());
+ m_page->settings().setMinimumFontSize(mainSettings.minimumFontSize());
+ m_page->settings().setMinimumLogicalFontSize(mainSettings.minimumLogicalFontSize());
// FIXME: Should we support enabling a11y while a popup is shown?
- m_page->settings().setAccessibilityEnabled(m_webView->page()->settings().accessibilityEnabled());
- m_page->settings().setScrollAnimatorEnabled(m_webView->page()->settings().scrollAnimatorEnabled());
+ m_page->settings().setAccessibilityEnabled(mainSettings.accessibilityEnabled());
+ m_page->settings().setScrollAnimatorEnabled(mainSettings.scrollAnimatorEnabled());
provideContextFeaturesTo(*m_page, wrapUnique(new PagePopupFeaturesClient()));
DEFINE_STATIC_LOCAL(FrameLoaderClient, emptyFrameLoaderClient, (EmptyFrameLoaderClient::create()));
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-minimum-font-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698