Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2359663002: wtf: Implement StringView specialization of string concatenation. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
Reviewers:
esprehn, Yuta Kitamura
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, jbroman+watch_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

wtf: Implement StringView specialization of string concatenation. Convert String and AtomicString specializations, which are trivially converted to StringView, to inherit from it as well. Add one site which uses the StringView specialization. Committed: https://crrev.com/f5683607b1d6d06f026744814a9b20ca11307ecf Cr-Commit-Position: refs/heads/master@{#420680}

Patch Set 1 #

Patch Set 2 : StringImpl::copyChars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -49 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringConcatenate.h View 1 1 chunk +15 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringConcatenate.cpp View 1 1 chunk +8 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringOperators.h View 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (19 generated)
jbroman
WDYT? Seems simpler, should perform well, and lets places which have StringView use them easily.
4 years, 3 months ago (2016-09-21 14:40:56 UTC) #10
Yuta Kitamura
LGTM on my part, let's wait for Elliot's response.
4 years, 3 months ago (2016-09-23 02:54:02 UTC) #13
esprehn
lgtm
4 years, 3 months ago (2016-09-23 08:49:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359663002/20001
4 years, 3 months ago (2016-09-23 12:31:17 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/284899)
4 years, 3 months ago (2016-09-23 12:44:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359663002/20001
4 years, 3 months ago (2016-09-23 13:36:59 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/262978)
4 years, 3 months ago (2016-09-23 13:55:50 UTC) #22
esprehn
lgtm
4 years, 3 months ago (2016-09-23 14:44:21 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359663002/20001
4 years, 3 months ago (2016-09-23 14:44:36 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/263031)
4 years, 3 months ago (2016-09-23 15:06:01 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359663002/20001
4 years, 3 months ago (2016-09-23 17:09:07 UTC) #29
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 18:50:30 UTC) #30
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 18:52:27 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5683607b1d6d06f026744814a9b20ca11307ecf
Cr-Commit-Position: refs/heads/master@{#420680}

Powered by Google App Engine
This is Rietveld 408576698