|
|
Descriptionwtf: Implement StringView specialization of string concatenation.
Convert String and AtomicString specializations, which are trivially converted
to StringView, to inherit from it as well.
Add one site which uses the StringView specialization.
Committed: https://crrev.com/f5683607b1d6d06f026744814a9b20ca11307ecf
Cr-Commit-Position: refs/heads/master@{#420680}
Patch Set 1 #Patch Set 2 : StringImpl::copyChars #
Messages
Total messages: 32 (19 generated)
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== WIP: StringView specialization of string concat operators BUG= ========== to ========== wtf: Implement StringView specialization of string concatenation. Convert String and AtomicString specializations, which are trivially converted to StringView, to inherit from it as well. ==========
Description was changed from ========== wtf: Implement StringView specialization of string concatenation. Convert String and AtomicString specializations, which are trivially converted to StringView, to inherit from it as well. ========== to ========== wtf: Implement StringView specialization of string concatenation. Convert String and AtomicString specializations, which are trivially converted to StringView, to inherit from it as well. Add one site which uses the StringView specialization. ==========
jbroman@chromium.org changed reviewers: + esprehn@chromium.org, yutak@chromium.org
WDYT? Seems simpler, should perform well, and lets places which have StringView use them easily.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM on my part, let's wait for Elliot's response.
lgtm
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
lgtm
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== wtf: Implement StringView specialization of string concatenation. Convert String and AtomicString specializations, which are trivially converted to StringView, to inherit from it as well. Add one site which uses the StringView specialization. ========== to ========== wtf: Implement StringView specialization of string concatenation. Convert String and AtomicString specializations, which are trivially converted to StringView, to inherit from it as well. Add one site which uses the StringView specialization. Committed: https://crrev.com/f5683607b1d6d06f026744814a9b20ca11307ecf Cr-Commit-Position: refs/heads/master@{#420680} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f5683607b1d6d06f026744814a9b20ca11307ecf Cr-Commit-Position: refs/heads/master@{#420680} |