Issue 2359613002: Set flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2359613002: Set flags. (Closed)

Created:
4 years, 3 months ago by Jana

Modified:
4 years, 3 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 2

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	net/quic/core/quic_flags_list.h	View		2 chunks	+3 lines, -3 lines	2 comments	Download

Depends on Patchset:

Issue 2352043004 Patch 1

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/2359613002/diff/1/net/quic/core/quic_flags_list.h File net/quic/core/quic_flags_list.h (left): https://codereview.chromium.org/2359613002/diff/1/net/quic/core/quic_flags_list.h#oldcode109 net/quic/core/quic_flags_list.h:109: QUIC_FLAG(bool, FLAGS_quic_reduce_sequencer_buffer_memory_life_time, true) Can you ping danzh? IIRC ...

4 years, 3 months ago (2016-09-20 22:25:50 UTC) #2

Jana

4 years, 3 months ago (2016-09-20 23:12:52 UTC) #3

https://codereview.chromium.org/2359613002/diff/1/net/quic/core/quic_flags_li...
File net/quic/core/quic_flags_list.h (left):

https://codereview.chromium.org/2359613002/diff/1/net/quic/core/quic_flags_li...
net/quic/core/quic_flags_list.h:109: QUIC_FLAG(bool,
FLAGS_quic_reduce_sequencer_buffer_memory_life_time, true)
On 2016/09/20 22:25:50, Ryan Hamilton wrote:
> Can you ping danzh? IIRC she's doing some chrome-side experimentation with
this
> flag.

Will do.

Expand Messages | Collapse Messages

Issue 2359613002: Set flags. (Closed)

Description

Patch Set 1 #

Messages