Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2359603002: Revert of [SVGDom] Opacity optimization (Closed)

Created:
4 years, 3 months ago by borenet
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of [SVGDom] Opacity optimization (patchset #4 id:60001 of https://codereview.chromium.org/2353503005/ ) Reason for revert: Failing assertion Original issue's description: > [SVGDom] Opacity optimization > > Apply opacity as fill/stroke paint alpha instead of saveLayer, when > possible. > > R=robertphillips@google.com,stephana@google.com,reed@google.com > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353503005 > > Committed: https://skia.googlesource.com/skia/+/3dbb7b9f196d793fbd16243157ee67638891f5dc TBR=reed@google.com,robertphillips@google.com,stephana@google.com,fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/a5344ee50a643ca72742e065f5268d9cbc3e0c82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -47 lines) Patch
M experimental/svg/model/SkSVGContainer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M experimental/svg/model/SkSVGContainer.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M experimental/svg/model/SkSVGNode.h View 1 chunk +0 lines, -2 lines 0 comments Download
M experimental/svg/model/SkSVGNode.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M experimental/svg/model/SkSVGRenderContext.h View 2 chunks +1 line, -6 lines 0 comments Download
M experimental/svg/model/SkSVGRenderContext.cpp View 2 chunks +4 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
borenet
Created Revert of [SVGDom] Opacity optimization
4 years, 3 months ago (2016-09-20 20:39:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359603002/1
4 years, 3 months ago (2016-09-20 20:39:44 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 20:39:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a5344ee50a643ca72742e065f5268d9cbc3e0c82

Powered by Google App Engine
This is Rietveld 408576698