Source/modules/webaudio/OscillatorNode.idl - Issue 23596014: Keep AudioScheduledSourceNode alive until onended is called.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/OscillatorNode.idl

Issue 23596014: Keep AudioScheduledSourceNode alive until onended is called. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Implement ActiveDOMObject::stop() Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/webaudio/OscillatorNode.idl

diff --git a/Source/modules/webaudio/OscillatorNode.idl b/Source/modules/webaudio/OscillatorNode.idl

index 949eac60c32695668c17a31b39d59360174a820f..82500fe4a75e7a938e21e3400a01bd852f647e66 100644

--- a/Source/modules/webaudio/OscillatorNode.idl

+++ b/Source/modules/webaudio/OscillatorNode.idl

@@ -24,7 +24,8 @@

// OscillatorNode is an audio generator of periodic waveforms.

[

- Conditional=WEB_AUDIO

+ Conditional=WEB_AUDIO,

+ ActiveDOMObject

] interface OscillatorNode : AudioSourceNode {

// Type constants.

@@ -48,7 +49,7 @@

readonly attribute AudioParam detune; // in Cents

void start(double when);

- void stop(double when);

+ [ImplementedAs=stopNote] void stop(double when);

void noteOn(double when);

void noteOff(double when);