pkg/source_maps/lib/parser.dart - Issue 23596007: Remove usage of dart:json. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(599)

My Issues | Starred Open | Closed | All

Unified Diff: pkg/source_maps/lib/parser.dart

Issue 23596007: Remove usage of dart:json. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebase. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « pkg/source_maps/lib/builder.dart ('k') | pkg/source_maps/test/builder_test.dart » ('j') | samples/third_party/dromaeo/tests/dom-modify-html.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/source_maps/lib/parser.dart

diff --git a/pkg/source_maps/lib/parser.dart b/pkg/source_maps/lib/parser.dart

index e2932634f158200bd72a3e21d53df2f82cadebea..6b8bf378089dc55f89822db1b10c72deb62bd6b3 100644

--- a/pkg/source_maps/lib/parser.dart

+++ b/pkg/source_maps/lib/parser.dart

@@ -5,7 +5,7 @@

/// Contains the top-level function to parse source maps version 3.

library source_maps.parser;

-import 'dart:json' as json;

+import 'dart:convert';

import 'span.dart';

import 'src/utils.dart';

@@ -15,7 +15,7 @@ import 'src/vlq.dart';

// TODO(sigmund): evaluate whether other maps should have the json parsed, or

// the string represenation.

Mapping parse(String jsonMap, {Map<String, Map> otherMaps}) =>

- parseJson(json.parse(jsonMap), otherMaps: otherMaps);

+ parseJson(JSON.decode(jsonMap), otherMaps: otherMaps);

/// Parses a source map directly from a json map object.

Mapping parseJson(Map map, {Map<String, Map> otherMaps}) {

« no previous file with comments | « pkg/source_maps/lib/builder.dart ('k') | pkg/source_maps/test/builder_test.dart » ('j') | samples/third_party/dromaeo/tests/dom-modify-html.dart » ('J')

Powered by Google App Engine

This is Rietveld 408576698