Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

Issue 2359583002: Change CronetUrlRequestContext slightly to allow reporting of BidirectionalStream's RequestFinished… (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
index 52afc3744099eafb412170514194f809a0133ce1..ce4b574633545e36439c14202768319cf32b3a59 100644
--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
@@ -429,7 +429,7 @@ public final class CronetUrlRequest implements UrlRequest {
mRequestMetricsAccumulator.onRequestFinished();
}
nativeDestroy(mUrlRequestAdapter, sendOnCanceled);
- mRequestContext.reportFinished(this);
+ mRequestContext.reportFinished(getRequestFinishedInfo());
mRequestContext.onRequestDestroyed();
mUrlRequestAdapter = 0;
if (mOnDestroyedCallbackForTesting != null) {
@@ -699,7 +699,7 @@ public final class CronetUrlRequest implements UrlRequest {
postTaskToExecutor(task);
}
- RequestFinishedInfo getRequestFinishedInfo() {
+ private RequestFinishedInfo getRequestFinishedInfo() {
// TODO(mgersh): fill in real values for finishedReason and exception
return new RequestFinishedInfo(mInitialUrl, mRequestAnnotations,
(mRequestMetricsAccumulator != null ? mRequestMetricsAccumulator.getRequestMetrics()
« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698