Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2359583002: Change CronetUrlRequestContext slightly to allow reporting of BidirectionalStream's RequestFinished… (Closed)

Created:
4 years, 3 months ago by xunjieli
Modified:
4 years, 3 months ago
Reviewers:
mgersh
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change CronetUrlRequestContext slightly to allow reporting of BidirectionalStream's RequestFinishedInfo This CL changes CronetUrlRequestContext#reportFinished slightly to allow BidirectionalStream to report RequestFinishedInfo as well. BUG=648346 Committed: https://crrev.com/1f85ba7bedef44c5de50c55b6f636f4173c7dbd6 Cr-Commit-Position: refs/heads/master@{#419840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
xunjieli
4 years, 3 months ago (2016-09-20 18:40:49 UTC) #2
mgersh
lgtm
4 years, 3 months ago (2016-09-20 18:47:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359583002/1
4 years, 3 months ago (2016-09-20 19:26:04 UTC) #9
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 3 months ago (2016-09-20 19:34:20 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 19:34:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f85ba7bedef44c5de50c55b6f636f4173c7dbd6
Cr-Commit-Position: refs/heads/master@{#419840}

Powered by Google App Engine
This is Rietveld 408576698