Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2359573003: [wasm] Reset the wasm_eh_prototype flag after unittests (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
John
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Reset the wasm_eh_prototype flag after unittests Changing the global state can effect the outcome of later tests. R=jpp@chromium.org Committed: https://crrev.com/d2c975d2173b6a97b77838c71d0fa3814b42ad91 Cr-Commit-Position: refs/heads/master@{#39595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M test/unittests/wasm/ast-decoder-unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 3 months ago (2016-09-21 09:15:06 UTC) #1
John
lgtm
4 years, 3 months ago (2016-09-21 13:13:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359573003/1
4 years, 3 months ago (2016-09-21 13:13:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 13:16:04 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 13:16:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2c975d2173b6a97b77838c71d0fa3814b42ad91
Cr-Commit-Position: refs/heads/master@{#39595}

Powered by Google App Engine
This is Rietveld 408576698