DevTools: fix keyboard navigation in "GoTo File" dialog

DevTools: fix keyboard navigation in "GoTo File" dialog

The ViewportControl.scrollItemIntoView mistakenly operates in terms of
first and last active elements; instead, it should rely on first and
last visible elements.

The patch also changes firstVisibleElements and lastVisibleElements
to always rely on cumulative heights.

BUG=none
R=einbinder

Committed: https://crrev.com/ec3b2760c702a5d913a2621e9f22205e74e33622
Cr-Commit-Position: refs/heads/master@{#420010}

[lushnikov, 2016-09-20 19:30:59]

please, take a look!

[lushnikov, 2016-09-20 20:33:49]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:34:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[einbinder, 2016-09-20 20:37:19]

lgtm

[lushnikov, 2016-09-20 20:54:26]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-09-20 20:54:26]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-09-20 20:54:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 00:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 00:02:51]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2016-09-21 07:29:34]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-09-21 07:29:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 09:05:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 09:06:34]

Description was changed from

==========
DevTools: fix keyboard navigation in "GoTo File" dialog

The ViewportControl.scrollItemIntoView mistakenly operates in terms of
first and last active elements; instead, it should rely on first and
last visible elements.

The patch also changes firstVisibleElements and lastVisibleElements
to always rely on cumulative heights.

BUG=none
R=einbinder
==========

to

==========
DevTools: fix keyboard navigation in "GoTo File" dialog

The ViewportControl.scrollItemIntoView mistakenly operates in terms of
first and last active elements; instead, it should rely on first and
last visible elements.

The patch also changes firstVisibleElements and lastVisibleElements
to always rely on cumulative heights.

BUG=none
R=einbinder

Committed: https://crrev.com/ec3b2760c702a5d913a2621e9f22205e74e33622
Cr-Commit-Position: refs/heads/master@{#420010}
==========

[commit-bot: I haz the power, 2016-09-21 09:06:35]

Patchset 1 (id:??) landed as
https://crrev.com/ec3b2760c702a5d913a2621e9f22205e74e33622
Cr-Commit-Position: refs/heads/master@{#420010}