Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: runtime/observatory/lib/src/elements/stack_trace_tree_config.dart

Issue 2359553002: Misc Observatory tweaks. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/stack_trace_tree_config.dart
diff --git a/runtime/observatory/lib/src/elements/stack_trace_tree_config.dart b/runtime/observatory/lib/src/elements/stack_trace_tree_config.dart
index 1e9e239de0cb62a611a031fa8d2a529aae2d3852..def0b64be3f5bf6ecebb0f8bba37fd225d3a05b0 100644
--- a/runtime/observatory/lib/src/elements/stack_trace_tree_config.dart
+++ b/runtime/observatory/lib/src/elements/stack_trace_tree_config.dart
@@ -161,6 +161,14 @@ class StackTraceTreeConfigElement extends HtmlElement implements Renderable {
return members;
}
+ String get modeDescription {
+ if (_mode == ProfileTreeMode.function) {
+ return 'Inlined frames expanded.';
+ } else {
+ return 'Inlined frames not expanded.';
+ }
+ }
+
List<Element> _createModeSelect() {
var s;
return [
@@ -174,11 +182,22 @@ class StackTraceTreeConfigElement extends HtmlElement implements Renderable {
}).toList(growable: false)
..onChange.listen((_) {
_mode = ProfileTreeMode.values[s.selectedIndex];
+ _r.dirty();
})
..onChange.map(_toEvent).listen(_triggerModeChange),
+ new SpanElement()
+ ..text = ' $modeDescription'
];
}
+ String get directionDescription {
+ if (_direction == M.ProfileTreeDirection.inclusive) {
+ return 'Tree is rooted at "main". Child nodes are callees.';
+ } else {
+ return 'Tree is rooted at top-of-stack. Child nodes are callers.';
+ }
+ }
+
List<Element> _createDirectionSelect() {
var s;
return [
@@ -193,12 +212,11 @@ class StackTraceTreeConfigElement extends HtmlElement implements Renderable {
}).toList(growable: false)
..onChange.listen((_) {
_direction = M.ProfileTreeDirection.values[s.selectedIndex];
+ _r.dirty();
})
..onChange.map(_toEvent).listen(_triggerDirectionChange),
new SpanElement()
- ..text = 'Tree is rooted at ' +
- (_direction == 'Down' ? '"main"' : 'function / code') +
- '. Child nodes are callers.'
+ ..text = ' $directionDescription'
];
}
« no previous file with comments | « runtime/observatory/lib/src/elements/ports.dart ('k') | runtime/observatory/lib/src/elements/timeline_page.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698