Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2359543003: Make sure unresolved function type parameter bounds do not end up in snapshot. (Closed)

Created:
4 years, 3 months ago by regis
Modified:
4 years, 3 months ago
Reviewers:
hausner, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make sure unresolved function type parameter bounds do not end up in snapshot. Read and write parent_level field of function type parameters in snapshots. Update TypeParameter::ToCString() to handle function type parameters. Address Siva's comments in previous cl. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/b91d74172a181179ab688478e55260dee3046f0e

Patch Set 1 #

Patch Set 2 : address Siva/s comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -21 lines) Patch
M runtime/vm/clustered_snapshot.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 5 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 1 4 chunks +29 lines, -15 lines 0 comments Download
M runtime/vm/parser.cc View 1 3 chunks +12 lines, -1 line 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
regis
This should fix the vm-app bots. Please, review asap, since Bill is waiting for this ...
4 years, 3 months ago (2016-09-20 19:38:41 UTC) #3
siva
lgtm
4 years, 3 months ago (2016-09-20 19:50:08 UTC) #4
regis
4 years, 3 months ago (2016-09-20 20:18:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b91d74172a181179ab688478e55260dee3046f0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698