Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2359533002: [inspector] replaced V8_INSPECTOR* macros with macros from base/macros.h (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
alph
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] replaced V8_INSPECTOR* macros with macros from base/macros.h BUG=chromium:635948 R=alph@chromium.org Committed: https://crrev.com/59f18e53b549886e037b1567fa6eb4d26cdcd49c Cr-Commit-Position: refs/heads/master@{#39572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -84 lines) Patch
D src/inspector/Allocator.h View 1 chunk +0 lines, -33 lines 0 comments Download
M src/inspector/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/inspector/InjectedScript.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/inspector/InjectedScript.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/inspector/InspectedContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/JavaScriptCallFrame.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/JavaScriptCallFrame.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/inspector/StringUtil.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8Console.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8Console.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/V8ConsoleAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8Debugger.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8Debugger.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M src/inspector/V8DebuggerAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8DebuggerScript.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8DebuggerScript.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/V8HeapProfilerAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8InspectorImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8InspectorSessionImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8ProfilerAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8Regex.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8Regex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/V8RuntimeAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8SchemaAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/V8StackTraceImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/inspector.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kozy
Alexei, please take a look!
4 years, 3 months ago (2016-09-20 17:31:36 UTC) #1
alph
lgtm
4 years, 3 months ago (2016-09-21 02:13:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359533002/1
4 years, 3 months ago (2016-09-21 03:40:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 04:23:10 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 04:23:26 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/59f18e53b549886e037b1567fa6eb4d26cdcd49c
Cr-Commit-Position: refs/heads/master@{#39572}

Powered by Google App Engine
This is Rietveld 408576698