LayoutTests/media/video-double-seek-currentTime.html - Issue 235953010: Resolve the issue of unexpected currentTime values when setting currentTime from seeking event

Side by Side Diff: LayoutTests/media/video-double-seek-currentTime.html

Issue 235953010: Resolve the issue of unexpected currentTime values when setting currentTime from seeking event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@mediaposter

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <video controls></video>
	acolwell GONE FROM CHROMIUM 2014/04/16 15:33:13 nit: Please add <!DOCTYPE html> and place this stu nit: Please add <!DOCTYPE html> and place this stuff inside <html><head> like a normal web page would be. Also move the <video> into a <body> tag and provide a test description in the <body> like other tests do.
	2 <script src=media-file.js></script>

	3 <script src=video-test.js></script>

	4 <script>

	5 var seekCount = 0;

	6 var expectedSeek = 0;

	7

	8 function log(str) {
	acolwell GONE FROM CHROMIUM 2014/04/16 15:33:13 Remove this function and replace all calls with co Remove this function and replace all calls with consoleWrite(). That is what the other tests use.
	9 var fragment = document.createDocumentFragment();

	10 fragment.appendChild(document.createTextNode(str));

	11 fragment.appendChild(document.createElement('br'));

	12

	13 document.querySelector("#log").appendChild(fragment);

	14 }

	15

	16 function seeking(e) {
	acolwell GONE FROM CHROMIUM 2014/04/16 15:33:13 nit: { for functions should be on the next line ju nit: { for functions should be on the next line just like in Blink C++ source files. Fix here and everywhere below.
	17 log("seeking " + e.target.currentTime);

	18

	19 doNextSeek(e.target);

	20 }

	21

	22 function seeked(e) {

	23 log("seeked " + e.target.currentTime);
	acolwell GONE FROM CHROMIUM 2014/04/16 15:33:13 nit: The logged value should be fixed as well to a nit: The logged value should be fixed as well to avoid platform differences.
	24

	25 var now = e.target.currentTime.toFixed(2);

	26 var expected = expectedSeek.toFixed(2);

	27 if (now != expected) {

	28 log('Expected ' + expectedSeek + ' got ' + now);
	acolwell GONE FROM CHROMIUM 2014/04/16 15:33:13 nit: use failTest() here and early return. nit: use failTest() here and early return.
	29 }

	30 testExpected("video.currentTime", 1.5)

	31 endTest();

	32 }

	33

	34 function doNextSeek(video) {

	35 log("doNextSeek() " + seekCount);

	36

	37 var newSeekPoint = -1;

	38 switch (seekCount) {
	acolwell GONE FROM CHROMIUM 2014/04/16 15:33:13 nit: fix indent. nit: fix indent.
	39 case 0:

	40 newSeekPoint = 1;

	41 break;

	42 case 1:

	43 newSeekPoint = 1.5;

	44 break;

	45 case 2:

	46 newSeekPoint = 1.5;

	47 break;

	48 };

	49

	50 if (newSeekPoint >= 0) {

	51 log('doNextSeek() seeking to ' + newSeekPoint);
	acolwell GONE FROM CHROMIUM 2014/04/16 15:33:13 nit: use toFixed() here. nit: use toFixed() here.
	52 expectedSeek = newSeekPoint;

	53 video.currentTime = newSeekPoint;

	54 }

	55 seekCount++;

	56 }

	57

	58 function loadedmetadata(e) {

	59 log("loadedmetadata() ");

	60 doNextSeek(e.target);

	61 }

	62

	63 function onWindowLoad(e) {

	64 //var video = document.getElementById('video');
	acolwell GONE FROM CHROMIUM 2014/04/16 15:33:13 nit: Please remove if this isn't needed. nit: Please remove if this isn't needed.
	65

	66 video.src = findMediaFile("video", "content/test");

	67 video.addEventListener('seeking', seeking);

	68 video.addEventListener('seeked', seeked);

	69 video.addEventListener('loadedmetadata', loadedmetadata);

	70 video.load();

	71 }

	72

	73 window.addEventListener('load', onWindowLoad, false);

	74 </script>

	75 <div id="log"> </div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/video-double-seek-currentTime-expected.txt » ('j') | LayoutTests/media/video-double-seek-currentTime-expected.txt » ('J')