Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 235953006: Enable libc++ under ASan by default. (Closed)

Created:
6 years, 8 months ago by Alexander Potapenko
Modified:
5 years, 9 months ago
Reviewers:
Nico, earthdok
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : enable libcxx only for ASan linux #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : try all_dependent_settings #

Patch Set 7 : Rebase after Sergey refactored libc++ #

Patch Set 8 : rebase #

Patch Set 9 : rebased after Sergey's change #

Patch Set 10 : rebase #

Patch Set 11 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (1 generated)
Alexander Potapenko
TBR Landing this now, let's see if it sticks.
6 years, 5 months ago (2014-07-22 08:29:28 UTC) #1
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 5 months ago (2014-07-22 08:29:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/235953006/200001
6 years, 5 months ago (2014-07-22 08:30:45 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 10:24:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 11:09:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41495)
6 years, 5 months ago (2014-07-22 11:09:59 UTC) #6
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 5 months ago (2014-07-22 11:39:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/235953006/200001
6 years, 5 months ago (2014-07-22 11:39:41 UTC) #8
commit-bot: I haz the power
Change committed as 284675
6 years, 5 months ago (2014-07-22 13:28:23 UTC) #9
earthdok
On 2014/07/22 13:28:23, I haz the power (commit-bot) wrote: > Change committed as 284675 Hooray! ...
6 years, 5 months ago (2014-07-22 13:30:16 UTC) #10
Nico
What's the advantage of using libc++ for asan?
5 years, 9 months ago (2015-02-28 01:03:15 UTC) #12
earthdok
On 2015/02/28 01:03:15, Nico wrote: > What's the advantage of using libc++ for asan? libc++ ...
5 years, 9 months ago (2015-02-28 14:04:59 UTC) #13
Nico
5 years, 9 months ago (2015-02-28 17:03:10 UTC) #14
Message was sent while issue was closed. 
On 2015/02/28 14:04:59, earthdok wrote:
> On 2015/02/28 01:03:15, Nico wrote:
> > What's the advantage of using libc++ for asan?
> 
> libc++ containers (actually only std::vector so far) are ASan-aware, allowing
us
> to catch bugs such as
https://code.google.com/p/chromium/issues/detail?id=409051
> another minor benefit is that you get nice stack traces in LSan when guts of
STL
> containers are leaked. with libstdc++, you can't unwind through it unless
> libstdc++-dbg is installed.

Ah right, thanks.

(It's usually a good idea to answer "why?" in CL descriptions; this prevents
(some) silly questions :-) )

Powered by Google App Engine
This is Rietveld 408576698