Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_util.cc

Issue 2359523003: Remove the Timing2 histograms that are deprecated. (Closed)
Patch Set: remove WasParseInForeground Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h" 5 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h" 9 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
10 #include "chrome/common/page_load_metrics/page_load_timing.h" 10 #include "chrome/common/page_load_metrics/page_load_timing.h"
11 11
12 namespace page_load_metrics { 12 namespace page_load_metrics {
13 13
14 bool WasStartedInForegroundOptionalEventInForeground( 14 bool WasStartedInForegroundOptionalEventInForeground(
15 const base::Optional<base::TimeDelta>& event, 15 const base::Optional<base::TimeDelta>& event,
16 const PageLoadExtraInfo& info) { 16 const PageLoadExtraInfo& info) {
17 return info.started_in_foreground && event && 17 return info.started_in_foreground && event &&
18 (!info.first_background_time || 18 (!info.first_background_time ||
19 event.value() <= info.first_background_time.value()); 19 event.value() <= info.first_background_time.value());
20 } 20 }
21 21
22 bool WasParseInForeground(const base::Optional<base::TimeDelta>& parse_start,
23 const base::Optional<base::TimeDelta>& parse_stop,
24 const PageLoadExtraInfo& info) {
25 if (!parse_start) {
26 return false;
27 }
28 const bool incomplete_parse_in_foreground =
29 !parse_stop && info.started_in_foreground && !info.first_background_time;
30
31 return incomplete_parse_in_foreground ||
32 WasStartedInForegroundOptionalEventInForeground(parse_stop, info);
33 }
34 } // namespace page_load_metrics 22 } // namespace page_load_metrics
OLDNEW
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_util.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698