Remove synthetic unresolved variables from async/await desugaring

Remove synthetic unresolved variables from async/await desugaring

This patch uses temporaries rather than unresolved variables for
.promise and .debug_is_active. For .promise, a new field is added
to the FunctionState, similarly to .generator_object. This change
fixes a bug where .promise was locally shadowable by with, affecting
program semantics.

BUG=v8:5405
Committed: https://crrev.com/bd078193a0502add9ff904f0e41150293604f954
Cr-Commit-Position: refs/heads/master@{#39566}

[Dan Ehrenberg, 2016-09-20 20:24:43]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:24:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-09-20 20:27:39]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:27:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-09-20 20:27:51]

littledan@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-09-20 20:42:04]

lgtm once this has a regression test

https://codereview.chromium.org/2359513002/diff/40001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2359513002/diff/40001/src/parsing/parser-base...
src/parsing/parser-base.h:1444: promise_variable_(NULL),
Nit: use nullptr here (might as well change the above while you're here).

[Dan Ehrenberg, 2016-09-20 21:00:36]

Added a regression test

https://codereview.chromium.org/2359513002/diff/40001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2359513002/diff/40001/src/parsing/parser-base...
src/parsing/parser-base.h:1444: promise_variable_(NULL),
On 2016/09/20 at 20:42:04, adamk wrote:
> Nit: use nullptr here (might as well change the above while you're here).

Done

[Dan Ehrenberg, 2016-09-20 21:00:39]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 21:00:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-09-20 21:01:36]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2016-09-20 21:01:38]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-09-20 21:01:38]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2359513002/#ps60001
(title: "regress test; nullptr")

[commit-bot: I haz the power, 2016-09-20 21:01:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-09-20 21:03:32]

Description was changed from

==========
Remove synthetic unresolved variables from async/await desugaring

This patch uses temporaries rather than unresolved variables for
.promise and .debug_is_active. For .promise, a new field is added
to the FunctionState, similarly to .generator_object. This change
fixes a bug where .promise was locally shadowable by with, affecting
program semantics.

BUG=v8:4505
==========

to

==========
Remove synthetic unresolved variables from async/await desugaring

This patch uses temporaries rather than unresolved variables for
.promise and .debug_is_active. For .promise, a new field is added
to the FunctionState, similarly to .generator_object. This change
fixes a bug where .promise was locally shadowable by with, affecting
program semantics.

BUG=v8:5405
==========

[Dan Ehrenberg, 2016-09-20 21:04:39]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-09-20 21:04:40]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2359513002/#ps80001
(title: "Fix bug number")

[commit-bot: I haz the power, 2016-09-20 21:04:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 21:30:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-20 21:31:36]

Description was changed from

==========
Remove synthetic unresolved variables from async/await desugaring

This patch uses temporaries rather than unresolved variables for
.promise and .debug_is_active. For .promise, a new field is added
to the FunctionState, similarly to .generator_object. This change
fixes a bug where .promise was locally shadowable by with, affecting
program semantics.

BUG=v8:5405
==========

to

==========
Remove synthetic unresolved variables from async/await desugaring

This patch uses temporaries rather than unresolved variables for
.promise and .debug_is_active. For .promise, a new field is added
to the FunctionState, similarly to .generator_object. This change
fixes a bug where .promise was locally shadowable by with, affecting
program semantics.

BUG=v8:5405

Committed: https://crrev.com/bd078193a0502add9ff904f0e41150293604f954
Cr-Commit-Position: refs/heads/master@{#39566}
==========

[commit-bot: I haz the power, 2016-09-20 21:31:37]

Patchset 5 (id:??) landed as
https://crrev.com/bd078193a0502add9ff904f0e41150293604f954
Cr-Commit-Position: refs/heads/master@{#39566}