Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: net/http/bidirectional_stream.h

Issue 2359493003: Add GetLoadTimingInfo to net::BidirectionalStream (Closed)
Patch Set: self review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/bidirectional_stream.cc » ('j') | net/http/bidirectional_stream.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/bidirectional_stream.h
diff --git a/net/http/bidirectional_stream.h b/net/http/bidirectional_stream.h
index c7fa97cdf687a731c33090a840f345df3cc68cdc..8fb222182d329e680efa1c5b626fa6d1ef786a23 100644
--- a/net/http/bidirectional_stream.h
+++ b/net/http/bidirectional_stream.h
@@ -14,6 +14,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
+#include "net/base/load_timing_info.h"
#include "net/http/bidirectional_stream_impl.h"
#include "net/http/http_stream_factory.h"
#include "net/log/net_log.h"
@@ -171,8 +172,8 @@ class NET_EXPORT BidirectionalStream
// not associated with any stream, and are not included in this value.
int64_t GetTotalSentBytes() const;
- // TODO(xunjieli): Implement a method to do flow control and a method to ping
- // remote end point.
+ // Get LoadTimingInfo of this stream.
+ void GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const;
private:
// BidirectionalStreamImpl::Delegate implementation:
@@ -246,11 +247,12 @@ class NET_EXPORT BidirectionalStream
// List of buffer length.
std::vector<int> write_buffer_len_list_;
- base::TimeTicks start_time_;
- base::TimeTicks read_start_time_;
+ // TODO(xunjieli): Remove this once LoadTimingInfo has response end.
base::TimeTicks read_end_time_;
- base::TimeTicks send_start_time_;
- base::TimeTicks send_end_time_;
+
+ // Load timing info of this stream. |connect_timing| is obtained when headers
+ // are received. Other fields are populated at different stages of the request
+ LoadTimingInfo load_timing_info_;
base::WeakPtrFactory<BidirectionalStream> weak_factory_;
« no previous file with comments | « no previous file | net/http/bidirectional_stream.cc » ('j') | net/http/bidirectional_stream.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698