third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h - Issue 2359493002: Prevent redundant DoWorks due to canceled delayed tasks (v2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h

Issue 2359493002: Prevent redundant DoWorks due to canceled delayed tasks (v2) (Closed)

Patch Set: Added a test and removed some code we probably don't need. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc » ('j') | third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h

diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h b/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h

index c6f2b29f5918544ddec4b74bf3a8032cbea5dd09..61f6136c0f59c0e26f5c3056123dfb5e2375b0e2 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h

+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h

@@ -172,8 +172,9 @@ class BLINK_PLATFORM_EXPORT TaskQueueImpl final : public TaskQueue {

}

// Enqueues any delayed tasks which should be run now on the

- // |delayed_work_queue|. Must be called from the main thread.

- void MoveReadyDelayedTasksToDelayedWorkQueue(LazyNow* lazy_now);

+ // |delayed_work_queue|. It also schedules the next wake up with the

+ // TimeDomain. Must be called from the main thread.

+ void WakeUpForDelayedWork(LazyNow* lazy_now);

private:

friend class WorkQueue;