Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h

Issue 2359493002: Prevent redundant DoWorks due to canceled delayed tasks (v2) (Closed)
Patch Set: Added a test and removed some code we probably don't need. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_VIRTUAL_TIME_DOMAIN_H_ 5 #ifndef THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_VIRTUAL_TIME_DOMAIN_H_
6 #define THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_VIRTUAL_TIME_DOMAIN_H_ 6 #define THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_VIRTUAL_TIME_DOMAIN_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "platform/scheduler/base/time_domain.h" 10 #include "platform/scheduler/base/time_domain.h"
(...skipping 11 matching lines...) Expand all
22 LazyNow CreateLazyNow() const override; 22 LazyNow CreateLazyNow() const override;
23 base::TimeTicks Now() const override; 23 base::TimeTicks Now() const override;
24 bool MaybeAdvanceTime() override; 24 bool MaybeAdvanceTime() override;
25 const char* GetName() const override; 25 const char* GetName() const override;
26 26
27 // Advances this time domain to |now|. NOTE |now| is supposed to be 27 // Advances this time domain to |now|. NOTE |now| is supposed to be
28 // monotonically increasing. NOTE it's the responsibility of the caller to 28 // monotonically increasing. NOTE it's the responsibility of the caller to
29 // call TaskQueueManager::MaybeScheduleImmediateWork if needed. 29 // call TaskQueueManager::MaybeScheduleImmediateWork if needed.
30 void AdvanceTo(base::TimeTicks now); 30 void AdvanceTo(base::TimeTicks now);
31 31
32 using TimeDomain::ClearExpiredWakeups;
33
34 protected: 32 protected:
35 void OnRegisterWithTaskQueueManager( 33 void OnRegisterWithTaskQueueManager(
36 TaskQueueManager* task_queue_manager) override; 34 TaskQueueManager* task_queue_manager) override;
37 void RequestWakeup(base::TimeTicks now, base::TimeDelta delay) override; 35 void RequestWakeup(base::TimeTicks now, base::TimeDelta delay) override;
38 void AsValueIntoInternal( 36 void AsValueIntoInternal(
39 base::trace_event::TracedValue* state) const override; 37 base::trace_event::TracedValue* state) const override;
40 38
41 void RequestDoWork(); 39 void RequestDoWork();
42 40
43 private: 41 private:
44 mutable base::Lock lock_; // Protects |now_|. 42 mutable base::Lock lock_; // Protects |now_|.
45 base::TimeTicks now_; 43 base::TimeTicks now_;
46 44
47 TaskQueueManager* task_queue_manager_; // NOT OWNED 45 TaskQueueManager* task_queue_manager_; // NOT OWNED
48 base::Closure do_work_closure_; 46 base::Closure do_work_closure_;
49 47
50 DISALLOW_COPY_AND_ASSIGN(VirtualTimeDomain); 48 DISALLOW_COPY_AND_ASSIGN(VirtualTimeDomain);
51 }; 49 };
52 50
53 } // namespace scheduler 51 } // namespace scheduler
54 } // namespace blink 52 } // namespace blink
55 53
56 #endif // THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_VIRTUAL_TIME_DOMAIN _H_ 54 #endif // THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_BASE_VIRTUAL_TIME_DOMAIN _H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698