Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2359483003: chromeos: Add a flag to launch with --mash. (Closed)

Created:
4 years, 3 months ago by sadrul
Modified:
4 years, 3 months ago
Reviewers:
Ilya Sherman, sky
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Add a flag to launch with --mash. Add a flag in chrome:flags to turn on the mojo ui service. The caveat is that it works OK (as in, you can successfully login) if a secondary user on the device turns on the flag. If the primary user/owner turns the flag on, then the flag is used in the login screen as well, and that does not work well yet. Even though secondary/non-owner users can turn the flag on and login, and see the chrome browser window (and other mus apps) without getting immediate crashes, a number of things are still in progress, and not implemented yet. So there are a number of missing features, and is somewhat unstable. BUG=633656 Committed: https://crrev.com/59e835de462f99529c7312b49926e2f0a67aa36e Cr-Commit-Position: refs/heads/master@{#420219}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M chrome/app/chrome_main.cc View 1 2 chunks +12 lines, -6 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (17 generated)
sadrul
4 years, 3 months ago (2016-09-20 22:42:14 UTC) #3
sky
Is this flag may leave you in a hosed state can you make it so ...
4 years, 3 months ago (2016-09-20 22:54:23 UTC) #7
sadrul
On 2016/09/20 22:54:23, sky wrote: > Is this flag may leave you in a hosed ...
4 years, 3 months ago (2016-09-21 02:09:02 UTC) #10
sky
LGTM
4 years, 3 months ago (2016-09-21 02:54:51 UTC) #13
sadrul
+isherman@ for histograms.xml
4 years, 3 months ago (2016-09-22 00:20:34 UTC) #19
Ilya Sherman
histograms.xml lgtm
4 years, 3 months ago (2016-09-22 00:48:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359483003/40001
4 years, 3 months ago (2016-09-22 00:53:26 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 00:59:52 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 01:02:40 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/59e835de462f99529c7312b49926e2f0a67aa36e
Cr-Commit-Position: refs/heads/master@{#420219}

Powered by Google App Engine
This is Rietveld 408576698