Send the WebMouseWheelEvents unconverted if Shift is down.

Send the WebMouseWheelEvents unconverted if Shift is down.

WebMouseWheelEvents were converted based on Shift getting set. This should
not happen. Instead swap the X&Y before we goto generate the scroll
gesture.

BUG=646109
Committed: https://crrev.com/d5d0c8bf89ad9b6a03122b6620bdbbdcd406bb79
Cr-Commit-Position: refs/heads/master@{#419966}

[dtapuska, 2016-09-20 15:04:02]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:04:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 15:45:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 15:45:07]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dtapuska, 2016-09-20 16:24:44]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 16:25:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 17:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 17:02:32]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[dtapuska, 2016-09-20 17:35:47]

Description was changed from

==========
Send the WebMouseWheelEvents unconverted if Shift is down.

WebMouseWheelEvents were converted based on Shift getting set. This should
not happen. Instead swap the X&Y before we goto generate the scroll
gesture.

BUG=646109
==========

to

==========
Send the WebMouseWheelEvents unconverted if Shift is down.

WebMouseWheelEvents were converted based on Shift getting set. This should
not happen. Instead swap the X&Y before we goto generate the scroll
gesture.

BUG=646109
==========

[dtapuska, 2016-09-20 17:35:47]

dtapuska@chromium.org changed reviewers:
+ mustaq@chromium.org

[mustaq, 2016-09-20 18:01:00]

https://codereview.chromium.org/2359463002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/mouse_wheel_event_queue.cc (right):

https://codereview.chromium.org/2359463002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/mouse_wheel_event_queue.cc:103: // Swap X&Y
if Shift is down.
Nit: "X & Y"

https://codereview.chromium.org/2359463002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/mouse_wheel_event_queue.cc:106:
event_sent_for_gesture_ack_->event.deltaX == 0) {
I don't quite see the role of deltaX == 0 here. Could you please explain? Why is
not deltaY considered?

[dtapuska, 2016-09-20 18:12:51]

https://codereview.chromium.org/2359463002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/mouse_wheel_event_queue.cc (right):

https://codereview.chromium.org/2359463002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/mouse_wheel_event_queue.cc:103: // Swap X&Y
if Shift is down.
On 2016/09/20 18:01:00, mustaq wrote:
> Nit: "X & Y"

Done.

https://codereview.chromium.org/2359463002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/mouse_wheel_event_queue.cc:106:
event_sent_for_gesture_ack_->event.deltaX == 0) {
On 2016/09/20 18:01:00, mustaq wrote:
> I don't quite see the role of deltaX == 0 here. Could you please explain? Why
is
> not deltaY considered?

Shift only modifies vertical movement provided there is no horizontal movement.
You can use a touchpad and move in both directions it won't swap. Or if you move
solely in a horizontal fashion it won't either.

[mustaq, 2016-09-20 18:14:27]

On 2016/09/20 18:12:51, dtapuska wrote:
>
https://codereview.chromium.org/2359463002/diff/20001/content/browser/rendere...
> File content/browser/renderer_host/input/mouse_wheel_event_queue.cc (right):
> 
>
https://codereview.chromium.org/2359463002/diff/20001/content/browser/rendere...
> content/browser/renderer_host/input/mouse_wheel_event_queue.cc:103: // Swap
X&Y
> if Shift is down.
> On 2016/09/20 18:01:00, mustaq wrote:
> > Nit: "X & Y"
> 
> Done.
> 
>
https://codereview.chromium.org/2359463002/diff/20001/content/browser/rendere...
> content/browser/renderer_host/input/mouse_wheel_event_queue.cc:106:
> event_sent_for_gesture_ack_->event.deltaX == 0) {
> On 2016/09/20 18:01:00, mustaq wrote:
> > I don't quite see the role of deltaX == 0 here. Could you please explain?
Why
> is
> > not deltaY considered?
> 
> Shift only modifies vertical movement provided there is no horizontal
movement.
> You can use a touchpad and move in both directions it won't swap. Or if you
move
> solely in a horizontal fashion it won't either.

Please add a comment in the code about it. LGTM otherwise. Thanks.

[dtapuska, 2016-09-20 20:09:52]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-09-20 20:09:52]

The patchset sent to the CQ was uploaded after l-g-t-m from mustaq@chromium.org
Link to the patchset: https://codereview.chromium.org/2359463002/#ps60001
(title: "Add comemnt")

[commit-bot: I haz the power, 2016-09-20 20:10:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 20:49:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 20:49:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dtapuska, 2016-09-21 02:19:24]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-09-21 02:20:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 03:39:56]

Description was changed from

==========
Send the WebMouseWheelEvents unconverted if Shift is down.

WebMouseWheelEvents were converted based on Shift getting set. This should
not happen. Instead swap the X&Y before we goto generate the scroll
gesture.

BUG=646109
==========

to

==========
Send the WebMouseWheelEvents unconverted if Shift is down.

WebMouseWheelEvents were converted based on Shift getting set. This should
not happen. Instead swap the X&Y before we goto generate the scroll
gesture.

BUG=646109
==========

[commit-bot: I haz the power, 2016-09-21 03:39:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-21 03:42:08]

Description was changed from

==========
Send the WebMouseWheelEvents unconverted if Shift is down.

WebMouseWheelEvents were converted based on Shift getting set. This should
not happen. Instead swap the X&Y before we goto generate the scroll
gesture.

BUG=646109
==========

to

==========
Send the WebMouseWheelEvents unconverted if Shift is down.

WebMouseWheelEvents were converted based on Shift getting set. This should
not happen. Instead swap the X&Y before we goto generate the scroll
gesture.

BUG=646109

Committed: https://crrev.com/d5d0c8bf89ad9b6a03122b6620bdbbdcd406bb79
Cr-Commit-Position: refs/heads/master@{#419966}
==========

[commit-bot: I haz the power, 2016-09-21 03:42:09]

Patchset 4 (id:??) landed as
https://crrev.com/d5d0c8bf89ad9b6a03122b6620bdbbdcd406bb79
Cr-Commit-Position: refs/heads/master@{#419966}