Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2359453002: Handle local functions in kernel_impact. (Closed)

Created:
4 years, 3 months ago by Johnni Winther
Modified:
4 years, 3 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -18 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 3 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_debug.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 4 chunks +25 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 6 chunks +58 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
4 years, 3 months ago (2016-09-20 13:55:30 UTC) #2
Johnni Winther
4 years, 3 months ago (2016-09-20 13:55:32 UTC) #3
Harry Terkelsen
lgtm https://codereview.chromium.org/2359453002/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2359453002/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode49 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:49: for (LocalFunctionElement localElement in kernel.localFunctions.keys) { localElement -> ...
4 years, 3 months ago (2016-09-20 18:03:30 UTC) #4
Johnni Winther
https://codereview.chromium.org/2359453002/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right): https://codereview.chromium.org/2359453002/diff/1/pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart#newcode49 pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:49: for (LocalFunctionElement localElement in kernel.localFunctions.keys) { On 2016/09/20 18:03:30, ...
4 years, 3 months ago (2016-09-21 08:57:07 UTC) #5
Johnni Winther
4 years, 3 months ago (2016-09-21 09:18:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b7d424f6fd588f1541d59a83d5b46eda37c3d0d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698