Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/gyp_chromium

Issue 235943009: Match only make in gyp_chromium excludes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
===================================================================
--- build/gyp_chromium (revision 263596)
+++ build/gyp_chromium (working copy)
@@ -10,6 +10,7 @@
import glob
import gyp_helper
import os
+import re
import shlex
import subprocess
import string
@@ -248,7 +249,7 @@
# We explicitly don't support the make gyp generator (crbug.com/348686). Be
# nice and fail here, rather than choking in gyp.
- if 'make' in os.environ.get('GYP_GENERATORS', ''):
+ if re.search('(^|,|\\s)make($|,|\\s)', os.environ.get('GYP_GENERATORS', '')):
Nico 2014/04/15 20:25:47 Use r'..\s..' instead of '..\\s..'
bungeman-chromium 2014/04/15 20:34:06 Done.
print 'Error: make gyp generator not supported (check GYP_GENERATORS).'
sys.exit(1)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698