Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 235943009: Match only make in gyp_chromium excludes. (Closed)

Created:
6 years, 8 months ago by bungeman-chromium
Modified:
6 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, viettrungluu
Visibility:
Public.

Description

Match only make in gyp_chromium excludes. The current test also matches the CMake generator. R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263984

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/gyp_chromium View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-chromium
I've been using the CMake gyp generator (mostly for editing with KDevelop), and I've had ...
6 years, 8 months ago (2014-04-15 20:23:30 UTC) #1
Nico
lgtm (I wonder if we can just delete this altogether, everyone should've seen this by ...
6 years, 8 months ago (2014-04-15 20:25:47 UTC) #2
bungeman-chromium
I have no real opinion on removing it, though it does seem nice to tell ...
6 years, 8 months ago (2014-04-15 20:34:06 UTC) #3
bungeman-chromium
6 years, 8 months ago (2014-04-15 20:34:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r263984 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698