Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 235943007: Handlify Object::ToObject. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -78 lines) Patch
M src/api.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/json-stringifier.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 chunks +17 lines, -45 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 4 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
6 years, 8 months ago (2014-04-14 07:24:33 UTC) #1
Benedikt Meurer
LGTM, with nit.
6 years, 8 months ago (2014-04-14 07:30:02 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/235943007/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/235943007/diff/1/src/objects-inl.h#newcode1079 src/objects-inl.h:1079: Handle<JSReceiver> Object::ToObject(Isolate* isolate, Handle<Object> object) { Nit: Can we ...
6 years, 8 months ago (2014-04-14 07:30:08 UTC) #3
Yang
On 2014/04/14 07:30:08, Benedikt Meurer wrote: > https://codereview.chromium.org/235943007/diff/1/src/objects-inl.h > File src/objects-inl.h (right): > > https://codereview.chromium.org/235943007/diff/1/src/objects-inl.h#newcode1079 ...
6 years, 8 months ago (2014-04-14 07:44:53 UTC) #4
Yang
6 years, 8 months ago (2014-04-14 09:19:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20711 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698