Issue 235943003: [FastTextAutosizer] Do not pre-inflate nested tables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235943003: [FastTextAutosizer] Do not pre-inflate nested tables (Closed)

Created:
6 years, 8 months ago by pdr.

Modified:
6 years, 8 months ago

Reviewers:
pdr, skobes (do not use), skobes

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[FastTextAutosizer] Do not pre-inflate nested tables Instead of pre-inflating all children in inflateTable(), this patch only pre-inflates non-table children. This fixes a bug where nested tables had their cell widths inflated with their parent table's multiplier but ended up not being inflated at all--leading to extra wide cells. This fixes a bug on codereview.chromium.org where people's names would have extra space around them (http://pr.gg/tablewidth.png). There is the potential for regressions with this change if a table has enough text to autosize but where the width ends up being less than 100% of the containing <td>. The real world impact script showed no changes on the top 100 websites and hackernews (the canonical nested- table mess) renders fine after this change. BUG=362930 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171420

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -19 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	LayoutTests/platform/mac/virtual/fasttextautosizing/fast/text-autosizing/tables/nested-table-wrapping-expected.png	View	Binary file		0 comments	Download
A +	LayoutTests/virtual/fasttextautosizing/fast/text-autosizing/tables/nested-table-wrapping.html	View	1 chunk	+9 lines, -15 lines	0 comments	Download
M	Source/core/rendering/FastTextAutosizer.cpp	View	1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/235943003/1

6 years, 8 months ago (2014-04-14 04:09:51 UTC) #4

Message was sent while issue was closed.

Change committed as 171420

Expand Messages | Collapse Messages