Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2359403002: [MD settings] remove condition on site list actionable state (Closed)

Created:
4 years, 2 months ago by dschuyler
Modified:
4 years, 2 months ago
Reviewers:
Finnur
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] remove condition on site list actionable state This CL removes a condition on whether a site settings row is 'actionable'. BUG=650557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a241e7aac6b340112403a9a9f4d2919a41972839 Cr-Commit-Position: refs/heads/master@{#421197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/site_settings/site_list.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
dschuyler
This CL is a bit of a touch-up for CL 2354313002 which changes the condition, ...
4 years, 2 months ago (2016-09-23 01:25:07 UTC) #5
Finnur
Yes, I agree. This is better. LGTM.
4 years, 2 months ago (2016-09-26 13:13:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359403002/1
4 years, 2 months ago (2016-09-26 18:19:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148341)
4 years, 2 months ago (2016-09-26 21:13:12 UTC) #12
Finnur
Updated bug link from 626615 to 650557 since QA filed it as a new bug. ...
4 years, 2 months ago (2016-09-27 13:27:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359403002/1
4 years, 2 months ago (2016-09-27 13:27:31 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 13:58:26 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 14:00:34 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a241e7aac6b340112403a9a9f4d2919a41972839
Cr-Commit-Position: refs/heads/master@{#421197}

Powered by Google App Engine
This is Rietveld 408576698