|
|
Created:
4 years, 2 months ago by dschuyler Modified:
4 years, 2 months ago Reviewers:
Finnur CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] remove condition on site list actionable state
This CL removes a condition on whether a site settings row is 'actionable'.
BUG=650557
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/a241e7aac6b340112403a9a9f4d2919a41972839
Cr-Commit-Position: refs/heads/master@{#421197}
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
Description was changed from ========== [MD settings] remove condition on site list actionable state This CL removes a condition on whether a site settings row is 'actionable'. BUG=626615 ========== to ========== [MD settings] remove condition on site list actionable state This CL removes a condition on whether a site settings row is 'actionable'. BUG=626615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + finnur@chromium.org
This CL is a bit of a touch-up for CL 2354313002 which changes the condition, but I think it's better removing the condition altogether. WDYT
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Yes, I agree. This is better. LGTM.
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== [MD settings] remove condition on site list actionable state This CL removes a condition on whether a site settings row is 'actionable'. BUG=626615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] remove condition on site list actionable state This CL removes a condition on whether a site settings row is 'actionable'. BUG=650557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Updated bug link from 626615 to 650557 since QA filed it as a new bug. Also looks like you (Dave) want to check this in but it failed due to env CQ issue, so I'm retrying on your behalf (to save time).
The CQ bit was checked by finnur@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [MD settings] remove condition on site list actionable state This CL removes a condition on whether a site settings row is 'actionable'. BUG=650557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] remove condition on site list actionable state This CL removes a condition on whether a site settings row is 'actionable'. BUG=650557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] remove condition on site list actionable state This CL removes a condition on whether a site settings row is 'actionable'. BUG=650557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] remove condition on site list actionable state This CL removes a condition on whether a site settings row is 'actionable'. BUG=650557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a241e7aac6b340112403a9a9f4d2919a41972839 Cr-Commit-Position: refs/heads/master@{#421197} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a241e7aac6b340112403a9a9f4d2919a41972839 Cr-Commit-Position: refs/heads/master@{#421197} |