tools/json_schema_compiler/test/permission_features_unittest.cc - Issue 23594008: Initial code generation for features.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/json_schema_compiler/test/permission_features_unittest.cc

Issue 23594008: Initial code generation for features. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Adding tests for real. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/json_schema_compiler/features_cc_generator.py ('K') | « tools/json_schema_compiler/test/json_schema_compiler_tests.gyp ('k') | tools/json_schema_compiler/test/test_permission_features.json » ('j') | tools/json_schema_compiler/test/test_permission_features.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include <string>
	not at google - send to devlin 2013/09/18 19:48:31 just features_unittest.cc just features_unittest.cc dhnishi (use Chromium) 2013/09/18 22:00:23 Done. Show quoted text On 2013/09/18 19:48:31, kalman wrote: > just features_unittest.cc Done.
	6

	7 #include "testing/gtest/include/gtest/gtest.h"

	8 #include "tools/json_schema_compiler/test/test_permission_features.h"

	9

	10 using test::features::PermissionFeatures;

	11

	12 TEST(FeaturesGeneratorTest, FromString) {

	13 PermissionFeatures test_features = PermissionFeatures();
	not at google - send to devlin 2013/09/18 19:48:31 just PermissionFeatures test_features; same belo just PermissionFeatures test_features; same below. dhnishi (use Chromium) 2013/09/18 22:00:23 Done. Show quoted text On 2013/09/18 19:48:31, kalman wrote: > just > > PermissionFeatures test_features; > > same below. Done.
	14 ASSERT_EQ(PermissionFeatures::kSimple, test_features.FromString("simple"));

	15 ASSERT_EQ(PermissionFeatures::kComplex, test_features.FromString("complex"));
	not at google - send to devlin 2013/09/18 19:48:31 for all, prefer EXPECT over ASSERT. for all, prefer EXPECT over ASSERT. dhnishi (use Chromium) 2013/09/18 22:00:23 Done. Show quoted text On 2013/09/18 19:48:31, kalman wrote: > for all, prefer EXPECT over ASSERT. Done.
	16 }

	17

	18 TEST(FeaturesGeneratorTest, ToString) {

	19 PermissionFeatures test_features = PermissionFeatures();

	20 ASSERT_EQ("simple",

	21 std::string(test_features.ToString(PermissionFeatures::kSimple)));

	22 ASSERT_EQ("complex",

	23 std::string(test_features.ToString(PermissionFeatures::kComplex)));
	not at google - send to devlin 2013/09/18 19:48:31 EXPECT_STREQ, no std::string-ifying. EXPECT_STREQ, no std::string-ifying. dhnishi (use Chromium) 2013/09/18 22:00:23 Done. Show quoted text On 2013/09/18 19:48:31, kalman wrote: > EXPECT_STREQ, no std::string-ifying. Done.
	24 }

OLD	NEW