Initial code generation for features.

tools/json_schema_compiler/features_cc_generator.py

+# Copyright (c) 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import os.path
+
+from code import Code
+import cpp_util
+
+
+class CCGenerator(object):
+  def Generate(self, permission_defs, source_file):

[not at google - send to devlin, 2013/09/13 21:37:52]

you need to remove references to "permissions", they're generic feature files.

[dhnishi (use Chromium), 2013/09/16 22:26:21]

Began phasing out references.

+    return _Generator(permission_defs, source_file).Generate()
+
+
+class _Generator(object):
+  """A .cc generator for PermissionFeatures.
+  """
+  def __init__(self, permission_defs, source_file):
+    self._feature_defs = cpp_util.RemoveFeatureDuplicates(permission_defs)
+    self._source_file = source_file
+    self._source_file_filename, _ = os.path.splitext(source_file)
+
+  def Generate(self):
+    """Generates a Code object for PermissionFeatures.
+    """
+    c = Code()
+    (c.Append(cpp_util.CHROMIUM_LICENSE)
+      .Append()
+      .Append(cpp_util.GENERATED_FEATURE_MESSAGE % self._source_file)
+      .Append()
+      .Append('#include <string>')
+      .Append()
+      .Append('#include "%s.h"' % self._source_file_filename)
+      .Append()
+      .Append('#include "base/logging.h"')
+      .Append()
+    )
+
+    # Generate the feature map singleton.
+    (c.Append('std::map<std::string, PermissionFeatures::ID>* '
+              '_FeatureMapSingleton() {')
+      .Sblock()
+      .Append('static std::map<std::string, PermissionFeatures::ID>* '
+              'singleton = new std::map<std::string, PermissionFeatures::ID>;')

[not at google - send to devlin, 2013/09/13 21:37:52]

You can't do this - it's a memory leak. Usually in Chrome code if you need a
singleton you use base::LazyInstance.

However, you don't need that here. Make the map just a member variable of
*Features. Let users of these files create base::LazyInstance<*Feature>s
themselves.

That involves making all of those methods non-static too, I suppose.

[dhnishi (use Chromium), 2013/09/16 22:26:21]

Made all of the methods non-static in preparation. 

I don't follow the other part, though. You want each Feature (PermissionFeature,
APIFeature, etc) would have its own map member variable?

I wasn't quite sure what was meant, so I made a private map instead of the
singleton pattern that was used before.

+      .Append('return singleton;')
+      .Eblock()
+      .Append('}')
+      .Append()
+    )
+
+    # Generate the constructor.
+    (c.Append('PermissionFeatures::PermissionFeatures() {')
+      .Sblock()
+    )
+    for feature in self._feature_defs:
+      c.Append('_FeatureMapSingleton()->insert(std::pair<std::string, '
+                   'PermissionFeatures::ID>("%s", %s));'
+                       % (feature.name, cpp_util.ConstantName(feature.name)))
+    (c.Eblock()
+      .Append('}')
+      .Append()
+    )
+
+    # Generate the ToString function.
+    (c.Append('const char* PermissionFeatures::ToString('
+                  'PermissionFeatures::ID id) {')
+      .Sblock()
+      .Append('switch (id) {')
+      .Sblock()
+    )
+    for feature in self._feature_defs:
+      c.Append('case %s: return "%s";' %
+          (cpp_util.ConstantName(feature.name), feature.name))
+    (c.Append('case kUnknown: break;')
+      .Append('case kEnumBoundary: break;')
+      .Eblock()
+      .Append('}')
+      .Append('NOTREACHED();')
+      .Append('return "";')
+    )
+    (c.Eblock()
+      .Append('}')
+      .Append()
+    )
+
+    # Generate the FromString function.
+    (c.Append('PermissionFeatures::ID PermissionFeatures::FromString(' \
+                  'const std::string& id) {')
+      .Sblock()
+      .Append('std::map<std::string, PermissionFeatures::ID>::const_iterator it'
+                  ' = _FeatureMapSingleton()->find(id);')
+      .Append('if (it == _FeatureMapSingleton()->end())')
+      .Append('  return kUnknown;')
+      .Append('return it->second;')
+      .Eblock()
+      .Append('}')
+      .Append()
+    )
+
+    return c