Initial code generation for features.

tools/json_schema_compiler/model.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os.path
 
 from json_parse import OrderedDict
 from memoize import memoize
 
 class ParseException(Exception):
@@ skipping 16 matching lines @@
 
   def AddNamespace(self, json, source_file, include_compiler_options=False):
     """Add a namespace's json to the model and returns the namespace.
     """
     namespace = Namespace(json,
                           source_file,
                           include_compiler_options=include_compiler_options)
     self.namespaces[namespace.name] = namespace
     return namespace
 
+class Feature(object):
+  """ A Feature

[not at google - send to devlin, 2013/09/12 16:20:43]

"""A feature, as specified in files such as
chrome/common/extensions/api/_permission_features.json.
"""

[dhnishi (use Chromium), 2013/09/13 17:36:42]

Done.

+
+  Properties:
+  - |name| the name of the feature
+  - |constant_name| the name of the constant equivalent to the feature
+  - |source_file| the file that contained the namespace definition
+  - |source_file_dir| the directory component of |source_file|
+  - |source_file_filename| the filename component of |source_file|
+  - |channel| the channel where the feature is released
+  - |extension_types| the types which can use the permission feature
+  - |whitelist| a list of exetnsions allowed to use the feature
+  """
+  def __init__(self, feature_name, feature_def, source_file):
+    self.name = feature_name
+    self.constant_name = self._constant_name(self.name)

[not at google - send to devlin, 2013/09/12 16:20:43]

this is a property of the C++ code not of the abstract model

[dhnishi (use Chromium), 2013/09/13 17:36:42]

Removed from the abstract model.

+    self.unix_name = UnixName(self.name)
+    self.source_file = source_file
+    self.source_file_dir, self.source_file_filename = os.path.split(source_file)

[not at google - send to devlin, 2013/09/12 16:20:43]

would be nice not to have source_file nor source_file_dir in this model either,
but I know that unfortunately other Model objects do have that. Ideally... not,
though.

[dhnishi (use Chromium), 2013/09/13 17:36:42]

I don't think I had anything actually using those variables, so I'll remove it.
I just had them there to mirror the other objects.

+    self.channel = feature_def['channel']
+    self.extension_types = feature_def['extension_types']
+    self.whitelist = feature_def.get('whitelist')
+
+  def _constant_name(self, target):

[not at google - send to devlin, 2013/09/12 16:20:43]

(move this into cpp_util.py if something like that isn't already there)

[dhnishi (use Chromium), 2013/09/13 17:36:42]

Done.

+    return ('k' + ''.join(word[0].upper() + word[1:]
+        for word in target.replace('.', ' ').split()))
+
 class Namespace(object):
   """An API namespace.
 
   Properties:
   - |name| the name of the namespace
   - |description| the description of the namespace
   - |unix_name| the unix_name of the namespace
   - |source_file| the file that contained the namespace definition
   - |source_file_dir| the directory component of |source_file|
   - |source_file_filename| the filename component of |source_file|
@@ skipping 437 matching lines @@
 def _GetPlatforms(json):
   if 'platforms' not in json:
     return None
   platforms = []
   for platform_name in json['platforms']:
     for platform_enum in _Enum.GetAll(Platforms):
       if platform_name == platform_enum.name:
         platforms.append(platform_enum)
         break
   return platforms
+

[not at google - send to devlin, 2013/09/12 16:20:43]

no blank line?

[dhnishi (use Chromium), 2013/09/13 17:36:42]

Done.