Adds media license nodes to cookie tree model and cookies view.

Adds media license nodes to cookie tree model and cookies view.

Adds a new node "Media license" when appropriate to the cookie
tree model and displayis it in the "Cookies and site data" dialog.
When selected, it displays details of media license (origin,
size on disk, last modified time) in the details frame.

BUG=649523
TEST=new tests pass
As well, nodes show up in the cookies dialog after visiting a site
that uses media licenses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e
Cr-Commit-Position: refs/heads/master@{#425166}

[jrummell, 2016-09-23 00:26:21]

Description was changed from

==========
Adds media license nodes to cookie tree model and cookies view.

Adds a new node "Media license" when appropriate to the cookie
tree model and displayis it in the "Cookies and site data" dialog.
When selected, it displays details of media license (origin,
size on disk, last modified time) in the details frame.

BUG=649523
TEST=new tests pass
As well, nodes show up in the cookies dialog after visiting a site
that uses media licenses.
==========

to

==========
Adds media license nodes to cookie tree model and cookies view.

Adds a new node "Media license" when appropriate to the cookie
tree model and displayis it in the "Cookies and site data" dialog.
When selected, it displays details of media license (origin,
size on disk, last modified time) in the details frame.

BUG=649523
TEST=new tests pass
As well, nodes show up in the cookies dialog after visiting a site
that uses media licenses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jrummell, 2016-09-23 00:36:21]

The CQ bit was checked by jrummell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 00:36:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jrummell, 2016-09-23 00:38:43]

jrummell@chromium.org changed reviewers:
+ dbeam@chromium.org, msramek@chromium.org, tzik@chromium.org

[jrummell, 2016-09-23 00:38:44]

PTAL. I choose the reviewers based on what git cl upload suggested, so please
let me know if somebody else would be a better fit for this change. Thanks.

[commit-bot: I haz the power, 2016-09-23 01:09:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 01:09:33]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[tzik, 2016-09-23 04:10:17]

tzik@chromium.org changed reviewers:
+ nhiroki@chromium.org

[tzik, 2016-09-23 04:10:19]

fileapi part lgtm.

nhiroki: Could you double check this?

[msramek, 2016-09-26 18:28:06]

This looks very good, but the red bots are relevant, so I'll wait for the fix
before giving L-G-T-M.

I left mostly nits and two questions related to the discrepancy that media
licenses sometimes behave like site data and sometimes like a separate datatype.

https://codereview.chromium.org/2359393002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2359393002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:10538: +      <message
name="IDS_COOKIES_MEDIA_LICENSE" desc="The text shown when there is an Media
License in the Cookies table">
Is there a reason why it's "media licenses" here but "content licenses" in the
Clear Browsing Data dialog? Is it again because of Flash?

I have the following scenario in mind:

1. The user deletes "Cookies and site data" in
chrome://settings/clearBrowserData
2. The user inspects cookies and site data in chrome://settings/cookies
3. The user sees that not everything was deleted - media licenses are there.
4. The user remembers that there was a checkbox for media licenses in
chrome://settings/clearBrowserData and understands that if they wanted media
licenses to be cleared, they should have checked that checkbox as well.

The fact that they are named differently in the two decreases the likelihood of
#4.

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/browsing_data_media_license_helper_unittest.cc
(right):

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_media_license_helper_unittest.cc:176:
std::string CreateFileSystem(const std::string& plugin_name,
nit: This method and everything below looks like it could / should be private.

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_media_license_helper_unittest.cc:258:
protected:
Why is this protected? Do we inherit from this test?

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/cookies_tree_model.cc (right):

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model.cc:132: case
CookieTreeNode::DetailedInfo::TYPE_MEDIA_LICENSE:
Hmm... it seems that media licenses are not protected by hosted apps.

Hosted apps can declare certain origins as BrowsingDataHelper::PROTECTED_WEB.
BrowsingDataRemover then takes it into account in the OriginMatcherFunction that
it passes to StoragePartitionImpl. However,
ClearPluginPrivateDataOnFileTaskRunner does not respect it.

So there are two options.
1. Move this to the "false" section.
2. If you think that hosted apps *should* protect content licenses, then we must
expand the "Hosted apps data" checkbox in CBD to include them.

I think the best course of action is to do 1. here, and optionally 2. in a
different CL.

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model.cc:1574:
CookieTreeMediaLicensesNode* media_license_node =
nit: license*s*

(this file is full of singular vs. plural distinctions, so it's kinda important
for readability)

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/cookies_tree_model_unittest.cc (right):

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model_unittest.cc:190: // media1.com
-> media_licenses -> media_license,
The hostname is just "media1", not "media1.com".

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model_unittest.cc:582: // 14.
`media1.com`
Ditto here.

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model_unittest.cc:590: // 22.
`xyz.com`, 2 nodes
nit: Why specify the number of nodes here and not elsewhere?

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model_unittest.cc:775: // media2.com
-> media_licenses -> media_license (3 objects)
Ditto here and below.

[jrummell, 2016-09-27 18:21:16]

Updated.

https://codereview.chromium.org/2359393002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2359393002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:10538: +      <message
name="IDS_COOKIES_MEDIA_LICENSE" desc="The text shown when there is an Media
License in the Cookies table">
On 2016/09/26 18:28:05, msramek wrote:
> Is there a reason why it's "media licenses" here but "content licenses" in the
> Clear Browsing Data dialog? Is it again because of Flash?
> 
> I have the following scenario in mind:
> 
> 1. The user deletes "Cookies and site data" in
> chrome://settings/clearBrowserData
> 2. The user inspects cookies and site data in chrome://settings/cookies
> 3. The user sees that not everything was deleted - media licenses are there.
> 4. The user remembers that there was a checkbox for media licenses in
> chrome://settings/clearBrowserData and understands that if they wanted media
> licenses to be cleared, they should have checked that checkbox as well.
> 
> The fact that they are named differently in the two decreases the likelihood
of
> #4.

In M54 "Content licenses" was changed to "Media licenses" in the Clear Browsing
Data dialog (https://codereview.chromium.org/2075023002/).

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/browsing_data_media_license_helper_unittest.cc
(right):

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_media_license_helper_unittest.cc:176:
std::string CreateFileSystem(const std::string& plugin_name,
On 2016/09/26 18:28:05, msramek wrote:
> nit: This method and everything below looks like it could / should be private.

Done.

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/browsing_data_media_license_helper_unittest.cc:258:
protected:
On 2016/09/26 18:28:05, msramek wrote:
> Why is this protected? Do we inherit from this test?

Made private. I think I used browsing_data_file_system_helper_unittest.cc as the
template for this class.

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/cookies_tree_model.cc (right):

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model.cc:132: case
CookieTreeNode::DetailedInfo::TYPE_MEDIA_LICENSE:
On 2016/09/26 18:28:06, msramek wrote:
> Hmm... it seems that media licenses are not protected by hosted apps.
> 
> Hosted apps can declare certain origins as BrowsingDataHelper::PROTECTED_WEB.
> BrowsingDataRemover then takes it into account in the OriginMatcherFunction
that
> it passes to StoragePartitionImpl. However,
> ClearPluginPrivateDataOnFileTaskRunner does not respect it.
> 
> So there are two options.
> 1. Move this to the "false" section.
> 2. If you think that hosted apps *should* protect content licenses, then we
must
> expand the "Hosted apps data" checkbox in CBD to include them.
> 
> I think the best course of action is to do 1. here, and optionally 2. in a
> different CL.

Done 1. Will follow up off-line about 2.

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model.cc:1574:
CookieTreeMediaLicensesNode* media_license_node =
On 2016/09/26 18:28:06, msramek wrote:
> nit: license*s*
> 
> (this file is full of singular vs. plural distinctions, so it's kinda
important
> for readability)

Done.

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/cookies_tree_model_unittest.cc (right):

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model_unittest.cc:190: // media1.com
-> media_licenses -> media_license,
On 2016/09/26 18:28:06, msramek wrote:
> The hostname is just "media1", not "media1.com".

Done.

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model_unittest.cc:582: // 14.
`media1.com`
On 2016/09/26 18:28:06, msramek wrote:
> Ditto here.

Done.

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model_unittest.cc:590: // 22.
`xyz.com`, 2 nodes
On 2016/09/26 18:28:06, msramek wrote:
> nit: Why specify the number of nodes here and not elsewhere?

I think I started here, and then realized it would be much clearer if I
commented on it closer to where the call to delete it was made (since this is a
huge test).

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model_unittest.cc:775: // media2.com
-> media_licenses -> media_license (3 objects)
On 2016/09/26 18:28:06, msramek wrote:
> Ditto here and below.

Done.

[jrummell, 2016-09-27 18:21:22]

The CQ bit was checked by jrummell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 18:21:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 19:39:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 19:39:36]

Dry run: This issue passed the CQ dry run.

[msramek, 2016-09-28 12:28:59]

LGTM

https://codereview.chromium.org/2359393002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2359393002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:10538: +      <message
name="IDS_COOKIES_MEDIA_LICENSE" desc="The text shown when there is an Media
License in the Cookies table">
On 2016/09/27 18:21:15, jrummell wrote:
> On 2016/09/26 18:28:05, msramek wrote:
> > Is there a reason why it's "media licenses" here but "content licenses" in
the
> > Clear Browsing Data dialog? Is it again because of Flash?
> > 
> > I have the following scenario in mind:
> > 
> > 1. The user deletes "Cookies and site data" in
> > chrome://settings/clearBrowserData
> > 2. The user inspects cookies and site data in chrome://settings/cookies
> > 3. The user sees that not everything was deleted - media licenses are there.
> > 4. The user remembers that there was a checkbox for media licenses in
> > chrome://settings/clearBrowserData and understands that if they wanted media
> > licenses to be cleared, they should have checked that checkbox as well.
> > 
> > The fact that they are named differently in the two decreases the likelihood
> of
> > #4.
> 
> In M54 "Content licenses" was changed to "Media licenses" in the Clear
Browsing
> Data dialog (https://codereview.chromium.org/2075023002/).

Apologies! I am of course aware of the change, I just misremembered that it was
in the opposite direction.

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
File chrome/browser/browsing_data/cookies_tree_model.cc (right):

https://codereview.chromium.org/2359393002/diff/1/chrome/browser/browsing_dat...
chrome/browser/browsing_data/cookies_tree_model.cc:132: case
CookieTreeNode::DetailedInfo::TYPE_MEDIA_LICENSE:
On 2016/09/27 18:21:15, jrummell wrote:
> On 2016/09/26 18:28:06, msramek wrote:
> > Hmm... it seems that media licenses are not protected by hosted apps.
> > 
> > Hosted apps can declare certain origins as
BrowsingDataHelper::PROTECTED_WEB.
> > BrowsingDataRemover then takes it into account in the OriginMatcherFunction
> that
> > it passes to StoragePartitionImpl. However,
> > ClearPluginPrivateDataOnFileTaskRunner does not respect it.
> > 
> > So there are two options.
> > 1. Move this to the "false" section.
> > 2. If you think that hosted apps *should* protect content licenses, then we
> must
> > expand the "Hosted apps data" checkbox in CBD to include them.
> > 
> > I think the best course of action is to do 1. here, and optionally 2. in a
> > different CL.
> 
> Done 1. Will follow up off-line about 2.

Acknowledged, discussed this off-line.

https://codereview.chromium.org/2359393002/diff/20001/chrome/browser/android/...
File chrome/browser/android/preferences/website_preference_bridge.cc (right):

https://codereview.chromium.org/2359393002/diff/20001/chrome/browser/android/...
chrome/browser/android/preferences/website_preference_bridge.cc:541: NULL,
nit: Prefer "nullptr" for new code. Could you perhaps change all NULLs in this
call?

[Dan Beam, 2016-09-29 02:54:20]

can you implement this only in /settings/ and not in /options/?

/options/ is deprecated and we're trying not to touch that code right now

[jrummell, 2016-09-29 21:58:31]

On 2016/09/29 02:54:20, Dan Beam wrote:
> can you implement this only in /settings/ and not in /options/?
> 
> /options/ is deprecated and we're trying not to touch that code right now

I've done it in both /settings/ and /options/ so it shows up in both the
original and the MD cookie dialogs. Do you want the original cookie dialog to
not show media licenses? Won't that be confusing to users?

[jrummell, 2016-09-29 22:07:37]

Updated.

https://codereview.chromium.org/2359393002/diff/20001/chrome/browser/android/...
File chrome/browser/android/preferences/website_preference_bridge.cc (right):

https://codereview.chromium.org/2359393002/diff/20001/chrome/browser/android/...
chrome/browser/android/preferences/website_preference_bridge.cc:541: NULL,
On 2016/09/28 12:28:59, msramek wrote:
> nit: Prefer "nullptr" for new code. Could you perhaps change all NULLs in this
> call?

Done.

[jrummell, 2016-09-29 22:07:47]

The CQ bit was checked by jrummell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 22:08:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 22:11:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 22:11:04]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[nhiroki, 2016-09-30 08:34:20]

https://codereview.chromium.org/2359393002/diff/40001/storage/browser/fileapi...
File storage/browser/fileapi/plugin_private_file_system_backend.cc (right):

https://codereview.chromium.org/2359393002/diff/40001/storage/browser/fileapi...
storage/browser/fileapi/plugin_private_file_system_backend.cc:304:
"application_x-ppapi-clearkey-cdm",  // ClearKey
I'd prefer to avoid widevine-specific code from the fileapi component as much as
possible. Could we replace these hard-coded strings with collecting supported
plugins from directory names like plugin_private_storage_helper.cc?

https://codereview.chromium.org/2359393002/diff/40001/storage/browser/fileapi...
storage/browser/fileapi/plugin_private_file_system_backend.cc:311:
base::File::FILE_OK) {
nit: Early-continue could be more readable because it can reduce the nest level:

if (OpenFSOnFileTaskRunner() != FILE_OK)
  continue;

[jrummell, 2016-10-03 19:05:47]

Updated.

https://codereview.chromium.org/2359393002/diff/40001/storage/browser/fileapi...
File storage/browser/fileapi/plugin_private_file_system_backend.cc (right):

https://codereview.chromium.org/2359393002/diff/40001/storage/browser/fileapi...
storage/browser/fileapi/plugin_private_file_system_backend.cc:304:
"application_x-ppapi-clearkey-cdm",  // ClearKey
On 2016/09/30 08:34:19, nhiroki (slow) wrote:
> I'd prefer to avoid widevine-specific code from the fileapi component as much
as
> possible. Could we replace these hard-coded strings with collecting supported
> plugins from directory names like plugin_private_storage_helper.cc?

Done.

https://codereview.chromium.org/2359393002/diff/40001/storage/browser/fileapi...
storage/browser/fileapi/plugin_private_file_system_backend.cc:311:
base::File::FILE_OK) {
On 2016/09/30 08:34:19, nhiroki (slow) wrote:
> nit: Early-continue could be more readable because it can reduce the nest
level:
> 
> if (OpenFSOnFileTaskRunner() != FILE_OK)
>   continue;

Done.

[jrummell, 2016-10-03 19:05:58]

The CQ bit was checked by jrummell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 19:06:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:13:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:13:18]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2016-10-04 08:42:44]

storage/browser/fileapi/ lgtm

https://codereview.chromium.org/2359393002/diff/60001/storage/browser/fileapi...
File storage/browser/fileapi/plugin_private_file_system_backend.cc (right):

https://codereview.chromium.org/2359393002/diff/60001/storage/browser/fileapi...
storage/browser/fileapi/plugin_private_file_system_backend.cc:309: //
directories so that data from any CDM used by this origin is deleted.
The last sentence ("... is deleted") is not appropriate for this case.

[nhiroki, 2016-10-04 08:53:53]

https://codereview.chromium.org/2359393002/diff/60001/storage/browser/fileapi...
File storage/browser/fileapi/plugin_private_file_system_backend.cc (right):

https://codereview.chromium.org/2359393002/diff/60001/storage/browser/fileapi...
storage/browser/fileapi/plugin_private_file_system_backend.cc:335: while
(!(current = enumerator->Next()).empty()) {
|current| is not used.

[jrummell, 2016-10-04 19:46:57]

Updated.

https://codereview.chromium.org/2359393002/diff/60001/storage/browser/fileapi...
File storage/browser/fileapi/plugin_private_file_system_backend.cc (right):

https://codereview.chromium.org/2359393002/diff/60001/storage/browser/fileapi...
storage/browser/fileapi/plugin_private_file_system_backend.cc:309: //
directories so that data from any CDM used by this origin is deleted.
On 2016/10/04 08:42:43, nhiroki (slow) wrote:
> The last sentence ("... is deleted") is not appropriate for this case.

Done.

https://codereview.chromium.org/2359393002/diff/60001/storage/browser/fileapi...
storage/browser/fileapi/plugin_private_file_system_backend.cc:335: while
(!(current = enumerator->Next()).empty()) {
On 2016/10/04 08:53:53, nhiroki (slow) wrote:
> |current| is not used.

Removed. I was using it to log the file name while testing.

[jrummell, 2016-10-04 19:48:50]

jrummell@chromium.org changed reviewers:
+ tedchoc@chromium.org

[jrummell, 2016-10-04 19:48:51]

+tedchoc@ for OWNERS review of
chrome/browser/android/preferences/website_preference_bridge.cc

[Ted C, 2016-10-04 20:02:14]

On 2016/10/04 19:48:51, jrummell wrote:
> +tedchoc@ for OWNERS review of
> chrome/browser/android/preferences/website_preference_bridge.cc

website_preference_bridge.cc - lgtm

[jrummell, 2016-10-04 21:59:39]

pinging dbeam@ in case he missed my comment on why there are changes in both
/settings/ and /options/ (so it shows up in both the original and the MD cookie
dialogs).

[Dan Beam, 2016-10-12 06:43:10]

Description was changed from

==========
Adds media license nodes to cookie tree model and cookies view.

Adds a new node "Media license" when appropriate to the cookie
tree model and displayis it in the "Cookies and site data" dialog.
When selected, it displays details of media license (origin,
size on disk, last modified time) in the details frame.

BUG=649523
TEST=new tests pass
As well, nodes show up in the cookies dialog after visiting a site
that uses media licenses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Adds media license nodes to cookie tree model and cookies view.

Adds a new node "Media license" when appropriate to the cookie
tree model and displayis it in the "Cookies and site data" dialog.
When selected, it displays details of media license (origin,
size on disk, last modified time) in the details frame.

BUG=649523
TEST=new tests pass
As well, nodes show up in the cookies dialog after visiting a site
that uses media licenses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-10-12 06:43:10]

dbeam@chromium.org changed reviewers:
+ dschuyler@chromium.org

[Dan Beam, 2016-10-12 06:43:27]

dbeam@chromium.org changed reviewers:
- dschuyler@chromium.org

[Dan Beam, 2016-10-13 05:04:04]

lgtm

[jrummell, 2016-10-13 17:30:59]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-10-13 17:31:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org,
msramek@chromium.org, nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2359393002/#ps80001
(title: "cleanup")

[commit-bot: I haz the power, 2016-10-13 17:31:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 17:50:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 17:50:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jrummell, 2016-10-13 20:19:55]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-10-13 20:19:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
msramek@chromium.org, tedchoc@chromium.org, dbeam@chromium.org,
nhiroki@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2359393002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-13 20:20:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 21:25:01]

Description was changed from

==========
Adds media license nodes to cookie tree model and cookies view.

Adds a new node "Media license" when appropriate to the cookie
tree model and displayis it in the "Cookies and site data" dialog.
When selected, it displays details of media license (origin,
size on disk, last modified time) in the details frame.

BUG=649523
TEST=new tests pass
As well, nodes show up in the cookies dialog after visiting a site
that uses media licenses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Adds media license nodes to cookie tree model and cookies view.

Adds a new node "Media license" when appropriate to the cookie
tree model and displayis it in the "Cookies and site data" dialog.
When selected, it displays details of media license (origin,
size on disk, last modified time) in the details frame.

BUG=649523
TEST=new tests pass
As well, nodes show up in the cookies dialog after visiting a site
that uses media licenses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-13 21:25:03]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-13 21:28:32]

Description was changed from

==========
Adds media license nodes to cookie tree model and cookies view.

Adds a new node "Media license" when appropriate to the cookie
tree model and displayis it in the "Cookies and site data" dialog.
When selected, it displays details of media license (origin,
size on disk, last modified time) in the details frame.

BUG=649523
TEST=new tests pass
As well, nodes show up in the cookies dialog after visiting a site
that uses media licenses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Adds media license nodes to cookie tree model and cookies view.

Adds a new node "Media license" when appropriate to the cookie
tree model and displayis it in the "Cookies and site data" dialog.
When selected, it displays details of media license (origin,
size on disk, last modified time) in the details frame.

BUG=649523
TEST=new tests pass
As well, nodes show up in the cookies dialog after visiting a site
that uses media licenses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e
Cr-Commit-Position: refs/heads/master@{#425166}
==========

[commit-bot: I haz the power, 2016-10-13 21:28:34]

Patchset 6 (id:??) landed as
https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e
Cr-Commit-Position: refs/heads/master@{#425166}