Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2359383002: setup_links.py: Use junctions instead of symlinks on Windows. (Closed)

Created:
4 years, 3 months ago by fbarchard1
Modified:
4 years, 3 months ago
Reviewers:
braveyao
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

setup_links.py: Use junctions instead of symlinks on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. Also clean up a few old documentation references to the Chromium SVN->Git transition. BUG=libyuv:584, webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. NOTRY=True R=braveyao@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/feaff94b51788b3c94974145c0ce4a79fdc4a675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -33 lines) Patch
M setup_links.py View 7 chunks +21 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
fbarchard1
4 years, 3 months ago (2016-09-23 00:51:32 UTC) #3
braveyao
lgtm
4 years, 3 months ago (2016-09-23 01:01:30 UTC) #4
braveyao
lgtm
4 years, 3 months ago (2016-09-23 01:01:32 UTC) #5
fbarchard1
4 years, 3 months ago (2016-09-23 01:26:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
feaff94b51788b3c94974145c0ce4a79fdc4a675 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698