MD Settings: Polish for Languages main page

chrome/browser/resources/settings/languages_page/add_languages_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-add-languages-dialog' is a dialog for enabling
  * languages.
  */
 Polymer({
   is: 'settings-add-languages-dialog',
@@ skipping 16 matching lines @@
 
     /** @private */
     disableActionButton_: {
       type: Boolean,
       value: true,
     },
   },
 
   attached: function() {
     this.$.dialog.showModal();
+    // Fire iron-resize after the list initially displays to prevent flickering.
+    var list = this.$$('iron-list');
+    setTimeout(list.fire.bind(list, 'iron-resize'));

[Dan Beam, 2016/09/23 23:25:42]

setTimeout(function() {
  this.$$('iron-list').fire('iron-resize');
}.bind(this));

is 1 line longer but likely much easier to read

[michaelpg, 2016/09/28 23:24:29]

Done.

   },
 
   /**
    * Returns the supported languages that are not yet enabled, based on
    * the LanguageHelper's enabled languages list.
    * @param {!Array<!chrome.languageSettingsPrivate.Language>}
    *     supportedLanguages
    * @param {!Object} enabledLanguagesChange Polymer change record for
    *     |enabledLanguages|.
    * @return {!Array<!chrome.languageSettingsPrivate.Language>}
@@ skipping 42 matching lines @@
   /**
    * Enables the checked languages.
    * @private
    */
   onActionButtonTap_: function() {
     this.$.dialog.close();
     for (var languageCode of this.languagesToAdd_)
       this.languageHelper.enableLanguage(languageCode);
   },
 });