Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2359343002: Fix the Windows component build. (Closed)

Created:
4 years, 3 months ago by dcheng
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, Azure Wei
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the Windows component build. Not sure why we don't have any coverage for all buildable targets on a Windows component build... BUG=none R=sky@chromium.org Committed: https://crrev.com/8a4057ee8ac4cf6f522de79ab7b025a727fb59a0 Cr-Commit-Position: refs/heads/master@{#420483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
This is a build fix after https://codereview.chromium.org/2323823004/
4 years, 3 months ago (2016-09-22 21:22:22 UTC) #1
sky
LGTM
4 years, 3 months ago (2016-09-22 21:25:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359343002/1
4 years, 3 months ago (2016-09-22 21:33:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 22:39:45 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 22:42:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a4057ee8ac4cf6f522de79ab7b025a727fb59a0
Cr-Commit-Position: refs/heads/master@{#420483}

Powered by Google App Engine
This is Rietveld 408576698