Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 235933010: deleteDatabase() success should be IDBVersionChangeEvent [Tests] (Closed)

Created:
6 years, 8 months ago by jsbell
Modified:
6 years, 8 months ago
Reviewers:
dgrogan, cmumford
CC:
blink-reviews, dgrogan, jsbell+idb_chromium.org, alecflett, ericu+idb_chromium.org, cmumford
Visibility:
Public.

Description

deleteDatabase() success should be IDBVersionChangeEvent [Tests] New tests only. Originally reviewed as part of crrev.com/235493003 but split out for a 3-part landing (blink, chromium, tests). TBR=dgrogan@chromium.org,cmumford@chromium.org BUG=362251 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171507

Patch Set 1 #

Patch Set 2 : Propagate typo fix to expected file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A LayoutTests/storage/indexeddb/deleteDatabase-event.html View 1 chunk +50 lines, -0 lines 0 comments Download
A + LayoutTests/storage/indexeddb/deleteDatabase-event-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 8 months ago (2014-04-14 16:41:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/235933010/1
6 years, 8 months ago (2014-04-14 16:41:31 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 17:06:38 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-14 17:06:39 UTC) #4
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 8 months ago (2014-04-14 18:23:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/235933010/20001
6 years, 8 months ago (2014-04-14 18:24:07 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 19:30:32 UTC) #7
Message was sent while issue was closed.
Change committed as 171507

Powered by Google App Engine
This is Rietveld 408576698