Issue 235933008: Move 'dir' attribute from HTMLDocument to Document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235933008: Move 'dir' attribute from HTMLDocument to Document. (Closed)

Created:
6 years, 8 months ago by Inactive

Modified:
6 years, 8 months ago

Reviewers:
tkent, arv (Not doing code reviews)

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, watchdog-blink-watchlist_google.com, rwlbuis, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move 'dir' attribute from HTMLDocument to Document. Move 'dir' attribute from HTMLDocument to Document to comply with the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#dom-document-dir This behavior is consistent with Firefox 28 and IE11. BUG=362955 TEST=fast/dom/dir-non-html-document.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171529

Patch Set 1 #

Patch Set 2 : Slight clean up #

Patch Set 3 : Move methods to a better location in Document.cpp #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -20 lines)			Patch
A	LayoutTests/fast/dom/dir-non-html-document.html	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/dir-non-html-document-expected.txt	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	Source/core/dom/Document.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	Source/core/dom/Document.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLDocument.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLDocument.cpp	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	Source/core/html/HTMLDocument.idl	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/235933008/40001

6 years, 8 months ago (2014-04-15 05:09:35 UTC) #4

Message was sent while issue was closed.

Change committed as 171529

Expand Messages | Collapse Messages